Allow setting metadata of vertices & edges#92
Open
blottn wants to merge 1 commit into
Open
Conversation
hmdsefi-poly
suggested changes
May 26, 2026
| inDegree int // number of incoming edges to this vertex | ||
| properties VertexProperties | ||
| metadata any // optional metadata associated with the vertex | ||
| Metadata any // optional metadata associated with the vertex |
There was a problem hiding this comment.
Please don’t expose the internal fields. Later, when we add concurrency, we’ll need those fields to remain private so they can be managed safely with locks.
There was a problem hiding this comment.
You can add setter methods if you need to modify the metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When storing data currently it needs to be all carried in the label. Allowing writing to the metadata would mean we can keep labels small and store actual data in the metadata field which is (as far as i can tell) unused.
I'm also open to moving to a field of a different name as "metadata" implies not the actual data.
I'd also be interested in lifting the type "any" to instead be a generic type of the vertex. Or perhaps converting vertex into an interface instead. Let me know if you think either of those are worthy changes.
This is my first contribution to this repo though so I'm happy to hear if I'm not seeing something :)!