Roster table and verified time

[RohanSGX]

Summary by CodeRabbit

• Bug Fixes
  • Disabled the "Roster Table and verify Time" navigation option in the Shift tab.

[coderabbitai]

Walkthrough

Two Facelets UI templates in the HR reports module are updated: the "(4) Roster Table and verify Time" navigation button in the Shift tab is disabled via HTML comment, and a minor formatting adjustment is applied to the shift report template's closing tag.

Changes

HR Reports UI Updates

Layer / File(s)	Summary
Shift tab navigation and template formatting src/main/webapp/hr/hr_reports.xhtml, src/main/webapp/hr/hr_report_shift_table.xhtml	The "(4) Roster Table and verify Time" p:commandButton in the Shift tab is commented out to disable that navigation option. The shift report template receives a minor end-of-file formatting adjustment to its closing </ui:composition> tag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• hmislk/hmis#20850: Both PRs modify src/main/webapp/hr/hr_reports.xhtml p:commandButton navigation items, with this PR disabling the "(4) Roster Table and verify Time" button while the other refactors HR report navigation targets across tabs.
• hmislk/hmis#20846: Both PRs modify the Shift tab's p:commandButton in hr_reports.xhtml, with this PR disabling the specific "(4) Roster Table and verify Time" button while the other updates navigation actions and path fixes.
• hmislk/hmis#20864: Both PRs modify Shift-tab navigation in hr_reports.xhtml by changing p:commandButton entries, with this PR commenting out the "(4) Roster Table and verify Time" button while the other updates the same navigation buttons' targets and URLs.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Roster table and verified time' is directly related to the main changes in the PR, which involve disabling the 'Roster Table and verify Time' navigation item in hr_reports.xhtml and a minor formatting update to hr_report_shift_table.xhtml.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch roster_table_and_verified_time

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/main/webapp/hr/hr_reports.xhtml (1)

181-184: ⚡ Quick win

Consider using rendered="false" instead of HTML comments.

While HTML comments work to disable the button, using the rendered="false" attribute is the preferred JSF approach for conditionally hiding UI elements. This keeps the code cleaner and more maintainable.

♻️ Suggested refactor

-                                                <!-- <p:commandButton value="(4) Roster Table and verify Time" 
+                                                <p:commandButton value="(4) Roster Table and verify Time" 
                                                                 action="/hr/hr_report_shift_table?faces-redirect=true" 
                                                                 actionListener="#{shiftTableController.makeTableNull()}"
-                                                                 class="w-100 my-1" ajax="false" /> -->
+                                                                 class="w-100 my-1" ajax="false" rendered="false" />

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/webapp/hr/hr_reports.xhtml` around lines 181 - 184, Replace the
commented-out p:commandButton with a real JSF component that uses
rendered="false" so it remains in the view but is not rendered; specifically
reintroduce the p:commandButton referencing the same action
"/hr/hr_report_shift_table?faces-redirect=true", actionListener
"#{shiftTableController.makeTableNull()}", ajax="false" and class attributes,
and add rendered="false" to hide it rather than leaving it inside an HTML
comment.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/main/webapp/hr/hr_reports.xhtml`:
- Around line 181-184: Replace the commented-out p:commandButton with a real JSF
component that uses rendered="false" so it remains in the view but is not
rendered; specifically reintroduce the p:commandButton referencing the same
action "/hr/hr_report_shift_table?faces-redirect=true", actionListener
"#{shiftTableController.makeTableNull()}", ajax="false" and class attributes,
and add rendered="false" to hide it rather than leaving it inside an HTML
comment.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: faa8f139-263a-412c-a948-9a54801997c2

📥 Commits

Reviewing files that changed from the base of the PR and between 22a0bd9 and e58758f.

📒 Files selected for processing (2)

• src/main/webapp/hr/hr_report_shift_table.xhtml
• src/main/webapp/hr/hr_reports.xhtml

[buddhika75]

This is a required function. Can not hide it