CARF-435 Change Link- Do you have a Unique Taxpayer Reference?#152
Merged
Conversation
ZDevelop94
reviewed
May 27, 2026
| writes: Writes[T], | ||
| rds: Reads[T] | ||
| ): UserAnswers = { | ||
| val updatedData = userAnswers.data.setObject(page.path, Json.toJson(value)) match { |
Contributor
There was a problem hiding this comment.
Does this fix my bug I found for tests? (however, still valid for main code)
Contributor
Author
There was a problem hiding this comment.
It fixes it for tests, yeah. The cleanup methods only effect things downstream of them, and only clears things if it's no longer valid, so it's more of a feature than a bug. (still need to be careful with it though)
ZDevelop94
previously approved these changes
May 27, 2026
ZDevelop94
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CARF-435
Test by going through the journey with scenarios in table on ticket, changing the value, and making sure the user gets to the correct url and the correct answers get changed