Skip to content

Gradle build-cache support  #9

@artemptushkin

Description

@artemptushkin

@MarvinSchramm it's a great thing that you wrote a plugin that supports Gradle configuration cache given the state of the Spring recommended plugin.

Problem

The plugin works for the configuration cache I can confirm but it doesn't for the build-cache

Another day I opened the issue in the latter mentioned plugin in regards to build-cache support but it wasn't addressed. And it's relevant for this

The problem is that git.properties becomes the part of outputs, so it affects the inputs of all the next tasks which makes it non-incremental.

Input property 'classpathSnapshotProperties.classpath' file /Users/artemptushkin/...build/resources/main/git.properties has changed.

Here is the relevant (same) code in the old plugin

Idea

I generate the git.properties file only when I build the image but the solution could be more generic:

  • make the dependency on the compilation toggleable and enabled by default (as it's now)
    • the clients will be able to disable the dependency for all the tasks but enable when they build the image (remote pipeline case)

If you address this, this plugin would be so much more compatible with Gradle, if I were Spring I'd start using yours!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions