-
Notifications
You must be signed in to change notification settings - Fork 168
Add descriptions to extension and service worker files #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,3 +1,8 @@ | ||||||||||||||||||
| /** | ||||||||||||||||||
| * @description Service Worker for caching static assets and handling push notifications. | ||||||||||||||||||
| * @author Son Nguyen <hoangson091104@gmail.com> | ||||||||||||||||||
| */ | ||||||||||||||||||
|
Comment on lines
+1
to
+4
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency with other files in the project (such as
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| const CACHE_NAME = "dashboard-v1"; | ||||||||||||||||||
| const SHELL = ["/", "/manifest.json", "/favicon.svg"]; | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,3 +1,8 @@ | ||||||||||||||||||
| /** | ||||||||||||||||||
| * Service Worker for Wiki PWA - Caches static assets and serves them when offline. | ||||||||||||||||||
| * @author Son Nguyen <hoangson091104@gmail.com> | ||||||||||||||||||
| */ | ||||||||||||||||||
|
Comment on lines
+1
to
+4
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To maintain consistency with the project's established documentation patterns, please add the
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| const CACHE_NAME = "wiki-v2"; | ||||||||||||||||||
| const PRECACHE = [ | ||||||||||||||||||
| "./", | ||||||||||||||||||
|
|
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introductory summary is incomplete as it omits several significant optional features covered in the guide, such as the MCP server, VS Code extension, and PWA installation. Providing a more inclusive summary helps users understand the full scope of the installation options at a glance.