Merged
Conversation
hoangsonww
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new GitHub Actions workflow to automate formatting, linting, and a final status report on pushes and PRs to master.
- Adds a CI/CD pipeline with separate jobs for formatting & linting and final status.
- Configures triggers on pushes and pull requests targeting
master. - Uses Ubuntu runners with Node.js setup and
npm ci,npm run format, andnpm run lint.
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:16
- Removing
continue-on-error: trueensures the pipeline fails on formatting or lint errors, preventing broken code from merging.
continue-on-error: true
.github/workflows/ci.yml:5
- If the repository's default branch is
main, this filter will prevent CI from running onmain. Update the branch name or includemain.
branches: [master]
| node-version: 18 | ||
| continue-on-error: true | ||
|
|
||
| - name: Install dependencies |
There was a problem hiding this comment.
Consider adding an actions/cache step for ~/.npm between checkout and install to speed up installs on subsequent runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.