Fixes all media playback bugs

Turns out I was wrong; the API I thought didn't work, actually
works great, but you have to unduck apps otherwise they'll ignore it.
Release audio focus request first; then call media button.

Author: hobbycommandline

USER_GUIDE.md

@@ -42,21 +42,14 @@ This will stop your music.
 
 - We first ask nicely, then force the app to stop if it didn't comply.
 - Hobby will close automatically after this action is complete.
-- Better complete control is available if I program it, but
-it would require a dangerous permission you really should
-never grant to an app, so this workaround will stick around
-if you don't enable said permission
 
 ## Resume current media
 
 Say
 
     Play
 
-- We can only ask nicely to play music, if the app refuses, we can't do anything about it. Music Player GO respects this command.
-- Launches the music player if no app responds to our play request.
-- Like stop, better control is possible if we accept a dangerous
-permission.
+- resumes playback of last played media
 - Hobby quits on complete
 
 ## Skip to next song
@@ -65,8 +58,7 @@ Say
 
     Next
 
-- We can only ask nicely, if the app refuses, we can't do anything about it. Music Player GO respects this command.
-- Better control if we use more dangerous permissions
+- Plays next media
 - Hobby quits on complete
 
 ## Skip to previous song
@@ -75,8 +67,7 @@ Say
 
     Previous
 
-- We can only ask nicely, if the app refuses, we can't do anything about it. Music Player GO respects this command.
-- Better control if we use more dangerous permissions
+- Plays previous media
 - Hobby quits on complete
 
 ## Launch a music player from search

app/src/main/assets/lua/actions/play.lua

@@ -1,37 +1,8 @@
 --[[resume playing of current song
   ;; play -> resume current audio
-  ;; possibly in future I will redirect to the "music" command as default if
-  ;; play fails?
 ]]
-require("lua/lib/say")
-require("lua/lib/intents")
-require("lua/lib/util")
-did_ok = false
-first = false
 function main()
-    jcall("sendMediaButtonActionCallback", {button=4, down=br(false), up=br(true)})
-    return "ok"
-end
-
-function launchPlay()
-    say("no app responded to play press, starting music activity")
-    local intent = {
-    action="android.intent.action.MAIN",
-    categories={"android.intent.category.LAUNCHER", "android.intent.category.APP_MUSIC"},
-    }
-    startActivity(intent)
+    jcall("sendMediaButtonAction", 4)
     jcall("quit")
-end
-
-function br(up)
-    function broadcastReceiver(code, data, intent)
-        if code == -1 then
-            did_ok = true
-            jcall("quit")
-        elseif first then
-            first = false
-        elseif up then
-            launchPlay()
-        end
-    end
+    return "ok"
 end

app/src/main/java/org/hobby/dispatcher/IntentDispatcher.kt

@@ -70,11 +70,9 @@ class IntentDispatcher {
         @JvmStatic fun sendMediaButtonAction(action: Long) {
             val context = MainActivity.context!!
             val keyCode = PlaybackStateCompat.toKeyCode(action)
-            val intent = Intent(Intent.ACTION_MEDIA_BUTTON)
-            intent.putExtra(Intent.EXTRA_KEY_EVENT, KeyEvent(KeyEvent.ACTION_DOWN, keyCode))
-            context.sendOrderedBroadcast(intent, null)
-            intent.putExtra(Intent.EXTRA_KEY_EVENT, KeyEvent(KeyEvent.ACTION_UP, keyCode))
-            context.sendOrderedBroadcast(intent, null)
+            val am = context.getSystemService(Context.AUDIO_SERVICE) as AudioManager
+            am.dispatchMediaKeyEvent(KeyEvent(KeyEvent.ACTION_DOWN, keyCode))
+            am.dispatchMediaKeyEvent(KeyEvent(KeyEvent.ACTION_UP, keyCode))
         }
 
         @JvmStatic fun stopMusic() {

app/src/main/java/org/hobby/dispatcher/LuaDispatcher.kt

@@ -115,7 +115,7 @@ class LuaDispatcher(id: Int) {
         fun copyAllResourcesToFiles() {
             val versionName = "version.txt"
             val updateRequired = BuildConfig.VERSION_NAME != readFile(versionName)
-            if (updateRequired) {
+            if (BuildConfig.DEBUG || updateRequired) {
                 if (!updateRequired && BuildConfig.DEBUG) {
                     LOG.severe("Copying initial files due to DEBUG flag");
                 }