fix: segfault with multichannel custom series #2307#2345
Closed
jschmer wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I recently attempted to improve the code that prepares |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: fix: segfault with multichannel custom series #2307
assignees: ''
Closes #2307
Description:
Fix for custom_series with multiple y channels. outConfig._transformedValues needs to be sized correctly for the plotter function to use it. It didn't match this expectation so the plotter function crashed/segfaulted with out of bounds memory access. The fix is to prepare correspondingly sized vectors in outConfig._transformedValues so that the plotter function can use it.