Skip to content

fix: Releasing GIL before attempts to lock the mutex #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoffstadt merged 2 commits into from
Dec 18, 2025
Merged

fix: Releasing GIL before attempts to lock the mutex #2581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feeaec6
fix: Releasing GIL before attempts to lock the mutex #2053
v-ein Dec 16, 2025
9453e71
fix: Fixed macOS build
v-ein Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ if(MV_TESTS_ONLY)
add_definitions(-DMV_TESTS_ONLY)
endif()

# Specifying MV_NO_USER_THREADS turns off some thread safety features (might give
# you some perf gain, yeah, those 0.01%) and must only be used when no user threads
# (threading.Thread) **ever** call DPG API. With MV_NO_USER_THREADS, it's only
# allowed to call DPG from the main thread and from handlers/callbacks.
# Also can be used to get back the behavior of old DPG versions that were thread
# unsafe (for testing/debugging).
set(MV_NO_USER_THREADS ${MV_NO_USER_THREADS})
if(MV_NO_USER_THREADS)
add_definitions(-DMV_NO_USER_THREADS)
endif()

add_subdirectory("thirdparty")

# if this is not a distribution build
Expand Down
Loading
Loading