Skip to content

Assert blocks inflight aren't cancelled when download destroyed - #811

Open
lejeunerenard wants to merge 1 commit into
mainfrom
test-destroy-download-keeps-inflight
Open

Assert blocks inflight aren't cancelled when download destroyed#811
lejeunerenard wants to merge 1 commit into
mainfrom
test-destroy-download-keeps-inflight

Conversation

@lejeunerenard

Copy link
Copy Markdown
Contributor
const r = core.download({ start: 0, end: source.length })
// moment to let X block reqs be sent
r.destroy()

Should not clear the X inflight. The .destroy() pattern is used to update ranges, so cancelling inflight blocks would cause many more messages to be sent.

@lejeunerenard
lejeunerenard requested a review from a team May 18, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant