feat: Include timestamp with group updates - #828
Open
Drache93 wants to merge 5 commits into
Open
Conversation
Includes timestamps in the group events, also moves the event to post flush to avoid races
chm-diederichs
previously approved these changes
Jun 1, 2026
One case where the adjustments `ongroupupdate` being called "misses" existing triggers is flushing an atom. This hits `_oncommit()` which always updated the index (if it has a group & is the default session). This caused it to trigger the hook. This is incorrect, so the moving of the hook to `lib/core.js`'s `ontruncate()` & `onappend()` fixes it. Currently it still triggers one event because `onappend()` is triggered without checking if any blocks are appended when flushing an atom.
lejeunerenard
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes timestamps in the group events, also moves the event to post
flush to avoid races