Skip to content

Data dependency#933

Open
NQPhuc wants to merge 67 commits into
masterfrom
data-dependency
Open

Data dependency#933
NQPhuc wants to merge 67 commits into
masterfrom
data-dependency

Conversation

@NQPhuc

@NQPhuc NQPhuc commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Short summary of the task, what have been done etc
  • Please include screenshots whenever possible (important).

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Lint Checks Passed
  • Unit Tests Passed
  • Coverage Tests Passed
  • Integration Tests Passed
  • Code Review

@NQPhuc
NQPhuc requested a review from huydo862003 June 22, 2026 09:37
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Benchmark Result

dbml-parse

suite 🏠 master 🔀 this branch change
18k 1104.995ms ±6.04% 1180.983ms ±4.15% 🔴 +6.9%
25k 1696.608ms ±3.39% 1778.812ms ±3.59% ⚪ +4.8%

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Coverage Report

Commit: aef5e6e

Overall Coverage

Metric Coverage
Lines ✅ 85.60% (9485/11081)
Statements ✅ 82.67% (10287/12443)
Functions ✅ 87.96% (1950/2217)
Branches ⚠️ 73.36% (6262/8536)

Package Coverage

Package Lines Statements Functions Branches
dbml-cli ✅ 100.00% ✅ 100.00% ✅ 100.00% ✅ 100.00%
dbml-connector ⚠️ 64.62% ⚠️ 64.36% ⚠️ 59.53% ⚠️ 59.09%
dbml-core N/A N/A N/A N/A
dbml-parse ✅ 87.55% ✅ 84.29% ✅ 90.35% ⚠️ 74.30%

⚠️ Coverage Warnings

The following packages have coverage below 80%:

  • dbml-connector: 64.62% line coverage

Files with Coverage Below 80%

dbml-connector

9 file(s) below 80% coverage
File Lines Statements Functions Branches
src/connectors/bigquery/index.ts 0.00% 0.00% 0.00% 0.00%
src/utils/credential-loader.ts 0.00% 0.00% 0.00% 0.00%
src/utils/helpers.ts 0.00% 0.00% 0.00% 0.00%
src/connectors/snowflake/index.ts 10.56% 10.31% 0.00% 0.00%
src/utils/parseSchema.ts 46.15% 42.85% 28.57% 27.27%
src/connectors/connector.ts 66.66% 66.66% 100.00% 57.14%
src/connectors/oracle/tables.ts 71.25% 67.39% 100.00% 56.96%
src/connectors/oracle/index.ts 80.00% 80.76% 100.00% 25.00%
src/connectors/oracle/utils.ts 85.71% 85.71% 100.00% 71.42%

dbml-parse

91 file(s) below 80% coverage
File Lines Statements Functions Branches
src/compiler/queries/container/scope.ts 0.00% 0.00% 0.00% 0.00%
src/services/diagnostics/provider.ts 0.00% 0.00% 0.00% 0.00%
src/compiler/queries/pipeline/interpret.ts 11.76% 13.51% 66.66% 41.66%
src/services/suggestions/crossFile.ts 19.35% 19.44% 33.33% 10.00%
src/core/local_modules/enum/index.ts 48.00% 46.29% 57.14% 52.63%
src/core/global_modules/project/interpret.ts 52.50% 46.66% 83.33% 23.07%
src/compiler/projectLayout/layout.ts 54.16% 53.84% 75.00% 52.63%
src/core/local_modules/dep/index.ts 59.37% 58.82% 100.00% 53.57%
src/compiler/queries/legacy/parse.ts 61.53% 53.33% 66.66% 25.00%
src/core/local_modules/ref/index.ts 62.50% 61.76% 100.00% 57.14%
src/core/types/report.ts 62.50% 55.55% 75.00% 57.14%
src/core/types/symbol/symbols.ts 62.69% 55.34% 59.83% 46.52%
src/core/global_modules/records/utils/data/values.ts 63.30% 55.71% 72.72% 49.28%
src/core/local_modules/tableGroup/validate.ts 64.55% 64.44% 71.42% 58.00%
src/compiler/queries/legacy/token.ts 66.66% 66.66% 66.66% 100.00%
src/core/global_modules/enum/bind.ts 66.66% 68.75% 83.33% 50.00%
src/core/local_modules/program/index.ts 66.66% 69.23% 75.00% 62.50%
src/core/global_modules/note/bind.ts 69.23% 71.42% 83.33% 50.00%
src/core/local_modules/checks/index.ts 69.23% 75.00% 100.00% 64.28%
src/core/local_modules/project/index.ts 69.23% 69.23% 100.00% 63.63%
src/core/local_modules/custom/index.ts 70.58% 71.42% 80.00% 68.75%
src/core/local_modules/tablePartial/validate.ts 73.12% 71.83% 79.22% 57.67%
src/compiler/queries/utils.ts 73.17% 73.43% 84.61% 52.17%
src/core/global_modules/project/bind.ts 73.33% 75.00% 100.00% 50.00%
src/core/local_modules/indexes/index.ts 73.68% 69.35% 63.63% 64.28%
src/core/local_modules/use/index.ts 73.91% 75.00% 75.00% 81.25%
src/core/local_modules/indexes/validate.ts 74.28% 74.66% 90.90% 56.00%
src/core/local_modules/note/index.ts 75.00% 75.86% 75.00% 72.72%
src/services/suggestions/utils/index.ts 75.00% 75.00% 100.00% 60.71%
src/core/local_modules/records/index.ts 75.60% 76.19% 100.00% 68.08%
src/core/local_modules/project/validate.ts 75.86% 75.86% 100.00% 56.25%
src/core/global_modules/indexes/bind.ts 76.31% 74.35% 90.90% 68.96%
src/core/global_modules/records/utils/data/sqlTypes.ts 76.59% 80.64% 82.35% 72.22%
src/core/global_modules/tablePartial/interpret.ts 78.12% 70.90% 78.94% 53.73%
src/core/global_modules/utils.ts 79.26% 77.01% 66.66% 69.04%
src/core/types/filepath.ts 79.48% 78.57% 77.77% 70.37%
src/core/global_modules/program/utils/external.ts 80.00% 80.00% 100.00% 70.00%
src/core/global_modules/tableGroup/bind.ts 80.00% 80.00% 100.00% 57.14%
src/core/local_modules/note/validate.ts 80.00% 78.18% 83.33% 73.68%
src/core/local_modules/records/validate.ts 80.28% 80.55% 93.75% 72.30%
src/core/global_modules/indexes/interpret.ts 81.39% 72.00% 100.00% 56.66%
__tests__/utils/compiler.ts 81.42% 80.10% 100.00% 58.97%
src/core/local_modules/tablePartial/index.ts 81.48% 81.48% 100.00% 77.27%
src/core/local_modules/diagramView/validate.ts 81.57% 78.04% 84.21% 72.72%
src/core/local_modules/checks/validate.ts 81.63% 82.69% 93.75% 70.00%
src/core/global_modules/records/bind.ts 82.92% 83.72% 93.75% 67.30%
src/compiler/queries/container/token.ts 83.33% 85.71% 100.00% 75.00%
src/core/local_modules/table/validate.ts 83.68% 84.32% 89.53% 71.19%
src/core/global_modules/ref/bind.ts 83.87% 83.87% 90.00% 75.00%
src/core/local_modules/enum/validate.ts 85.48% 81.81% 81.25% 76.31%
src/core/parser/parser.ts 85.50% 85.71% 100.00% 76.96%
__tests__/utils/mocks.ts 85.71% 86.20% 75.00% 100.00%
src/compiler/queries/transform/syncDep.ts 85.71% 74.21% 80.00% 59.84%
src/core/local_modules/dep/validate.ts 85.71% 82.60% 93.33% 75.00%
src/core/global_modules/use/index.ts 86.59% 83.20% 100.00% 78.22%
src/services/suggestions/utils/useMerger.ts 86.95% 81.13% 100.00% 46.34%
src/core/global_modules/tablePartial/bind.ts 87.03% 87.27% 100.00% 71.42%
src/compiler/queries/transform/utils/index.ts 87.23% 78.33% 90.00% 75.80%
src/compiler/queries/transform/updateElementSetting.ts 87.50% 87.87% 100.00% 73.77%
src/services/suggestions/provider.ts 88.19% 84.50% 95.31% 77.57%
src/core/global_modules/tableGroup/interpret.ts 88.37% 88.37% 100.00% 77.27%
src/services/suggestions/recordRowSnippet.ts 88.46% 87.09% 100.00% 73.80%
src/compiler/queries/nodeAtPosition.ts 88.88% 90.00% 100.00% 75.00%
src/core/global_modules/diagramView/index.ts 89.16% 86.23% 83.33% 78.18%
src/core/utils/note.ts 89.65% 87.14% 100.00% 78.33%
src/core/global_modules/records/index.ts 90.90% 87.15% 100.00% 79.16%
src/compiler/index.ts 91.66% 91.72% 78.94% 82.00%
src/core/global_modules/records/utils/constraints/pk.ts 91.66% 88.88% 93.75% 63.15%
src/core/global_modules/table/index.ts 91.75% 90.32% 100.00% 77.83%
src/core/types/symbol/metadata.ts 91.84% 80.00% 98.43% 65.46%
src/core/global_modules/table/interpret.ts 91.89% 83.52% 95.83% 66.66%
src/core/global_modules/schema/index.ts 92.26% 82.46% 91.66% 70.07%
src/core/utils/interpret.ts 93.33% 90.00% 100.00% 73.23%
src/core/global_modules/diagramView/interpret.ts 94.59% 90.40% 92.85% 75.75%
src/services/suggestions/use.ts 94.68% 87.61% 100.00% 77.45%
src/core/global_modules/note/interpret.ts 95.65% 95.65% 100.00% 75.00%
src/core/global_modules/records/interpret.ts 95.97% 92.59% 100.00% 79.54%
__tests__/examples/interpreter/multifile/utils.ts 96.00% 89.65% 100.00% 62.50%
src/core/global_modules/dep/bind.ts 96.00% 79.68% 100.00% 69.56%
src/core/global_modules/dep/interpret.ts 96.93% 92.72% 100.00% 76.19%
src/compiler/queries/canonicalName.ts 96.96% 92.10% 100.00% 76.66%
src/core/global_modules/program/interpret.ts 97.01% 93.95% 100.00% 72.16%
src/core/global_modules/tableGroup/index.ts 97.36% 91.30% 100.00% 78.78%
src/core/global_modules/program/utils/records.ts 98.30% 88.88% 100.00% 68.18%
src/core/types/errors.ts 98.55% 98.55% 66.66% 100.00%
src/compiler/queries/transform/renameTable.ts 99.05% 90.47% 100.00% 78.82%
src/compiler/queries/transform/utils/ref.ts 100.00% 82.92% 100.00% 64.70%
src/core/global_modules/checks/interpret.ts 100.00% 88.88% 100.00% 60.00%
src/core/global_modules/program/index.ts 100.00% 85.71% 100.00% 75.00%
src/core/global_modules/records/utils/constraints/unique.ts 100.00% 94.28% 100.00% 58.33%
src/services/definition/provider.ts 100.00% 95.23% 100.00% 71.42%

Comment thread packages/dbml-parse/src/core/local_modules/table/validate.ts
Comment thread packages/dbml-parse/src/core/local_modules/dep/validate.ts
Comment thread packages/dbml-parse/src/core/local_modules/custom/validate.ts
@huydo862003

Copy link
Copy Markdown
Contributor

Pls help run lint:fix nhe :v

Comment thread packages/dbml-parse/src/core/global_modules/table/index.ts Outdated
Comment thread packages/dbml-parse/src/core/global_modules/table/index.ts Outdated
Comment thread packages/dbml-parse/src/core/global_modules/table/index.ts Outdated
Comment thread packages/dbml-parse/src/core/global_modules/table/interpret.ts Outdated
Comment thread packages/dbml-parse/src/core/types/schemaJson.ts
Comment thread packages/dbml-parse/src/core/types/schemaJson.ts
Comment thread packages/dbml-parse/src/core/types/symbol/metadata.ts

@huydo862003 huydo862003 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the language services for dep luôn nha :v can reference ref

Comment thread packages/dbml-core/src/export/DbmlExporter.ts Outdated
Comment thread packages/dbml-core/src/export/DbmlExporter.ts
Comment thread packages/dbml-core/src/export/DbmlExporter.ts Outdated
Comment thread packages/dbml-core/src/export/DbmlExporter.ts Outdated
Comment thread packages/dbml-core/src/parse/ANTLR/ASTGeneration/mysql/MySQLASTGen.js Outdated
@huydo862003
huydo862003 force-pushed the data-dependency branch 2 times, most recently from fc252fb to 9f9d7db Compare July 16, 2026 02:20
@huydo862003 huydo862003 mentioned this pull request Jul 16, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants