Configurable stream select#77
Open
sanderdlm wants to merge 8 commits into
Open
Conversation
added 8 commits
March 27, 2023 17:19
Passing a string to any Request is deprecated in 4.x
This method had a bug where, as long as no error was thrown, or timeout reached, it would report that all sockets inside a collection had responses even if some of them did not. Checking each socket individually in a loop is a performance hit, but the only way to report accuratly if a socket has a response ready.
…quests This will be passed to the socket as soon as the request is sent. The polling timeout will then be used by the hasResponse method, which uses stream_select
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempted fix for #18. Implemented option 3 from this comment. This timeout now also applies to the multi requests since the
getSocketIdsHavingResponsehas been reworked to simply usehasResponsein a loop. This is slower than using stream_select on all resources at the same time, but the only way to accurately determine which sockets have responses.Tried to figure out a test, but couldn't find way to get a socket/check it's timeout just by having the ID. Should we make a basic
getSocketByIdmethod publicly available? Or$client->sockets->getById?