Code quality updates (#1738)

Author: maximlt

.pre-commit-config.yaml

@@ -14,12 +14,12 @@ repos:
         exclude: (\.min\.js$|\.svg$)
       - id: trailing-whitespace
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: b969e2851312ca2b24bbec879ba4954341d1bd12 # frozen: v0.15.5
+    rev: 01a675ea018f2fb714478a5ffb83fcea8374bb06  # frozen: v0.15.21
     hooks:
       - id: ruff-check
       - id: ruff-format
   - repo: https://github.com/hoxbro/clean_notebook
-    rev: 2e6f506fab3cdfbe16bc18fd0d24e828db773b74 # frozen: v0.2.1
+    rev: ba97036e6f0408aa318165535665c35a9423c352  # frozen: v0.2.1
     hooks:
       - id: clean-notebook
         args: [-i, tags]

doc/_ext/backend_styling_options.py

@@ -1,12 +1,10 @@
+import holoviews as hv
 from docutils import nodes
 from docutils.statemachine import StringList
 from sphinx.util.docutils import SphinxDirective
 
-import holoviews as hv
-
 from hvplot.util import _get_backend_style_options
 
-
 hv.extension('bokeh', 'matplotlib')
 
 

doc/_ext/plotting_options_table.py

@@ -8,12 +8,12 @@
 """
 
 import sys
-
 from textwrap import indent
 
-from hvplot.util import _get_docstring_group_parameters
 from sphinx.util.docutils import SphinxDirective
 
+from hvplot.util import _get_docstring_group_parameters
+
 
 class PlottingOptionsTableDirective(SphinxDirective):
     """

doc/conf.py

@@ -5,36 +5,38 @@
 sys.path.insert(0, os.path.abspath('_ext'))
 
 import os
+
 import param
 import pydata_sphinx_theme
 
 param.parameterized.docstring_signature = False
 param.parameterized.docstring_describe_params = False
 
-import hvplot  # noqa
-from nbsite.shared_conf import *  # noqa
+from nbsite.shared_conf import *  # noqa: E402, F403
+
+import hvplot  # noqa: E402
 
 project = 'hvPlot'
 authors = 'HoloViz developers'
-copyright_years['start_year'] = '2016'  # noqa
-copyright = copyright_fmt.format(**copyright_years)  # noqa
+copyright_years['start_year'] = '2016'  # noqa: F405
+copyright = copyright_fmt.format(**copyright_years)  # noqa: F405
 description = 'A high-level plotting API for the PyData ecosystem built on HoloViews'
 
-version = release = base_version(hvplot.__version__)  # noqa
+version = release = base_version(hvplot.__version__)  # noqa: F405
 nbbuild_cell_timeout = 600
 
 # Useful for SEO on a versioned site
 html_baseurl = 'https://hvplot.holoviz.org/en/docs/latest/'
 
 exclude_patterns = ['governance']
 
-html_static_path += ['_static']  # noqa
+html_static_path += ['_static']  # noqa: F405
 
 if pydata_sphinx_theme.__version__ == '0.16.1':
     # See https://github.com/pydata/pydata-sphinx-theme/issues/2088
-    templates_path.append('_static/patch_templates')  # noqa
+    templates_path.append('_static/patch_templates')  # noqa: F405
 
-html_css_files += ['custom.css']  # noqa
+html_css_files += ['custom.css']  # noqa: F405
 
 html_js_files = [
     'https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.4/require.min.js',
@@ -44,7 +46,7 @@
     if any(pr in hvplot.__version__ for pr in ('a', 'b', 'rc', 'dev'))
     else version
 )
-html_theme_options.update(  # noqa
+html_theme_options.update(  # noqa: F405
     {
         'navbar_start': ['navbar-logo', 'version-switcher'],
         'use_edit_page_button': True,
@@ -67,7 +69,7 @@
             },
         ],
         'pygments_dark_style': 'material',
-        'announcement': "hvPlot 0.12 has just been released! Checkout the <a href='https://blog.holoviz.org/posts/hvplot_release_0.12/'>blog post</a> and support hvPlot by giving it a 🌟 on <a href='https://github.com/holoviz/hvplot'>Github</a>.",
+        'announcement': "hvPlot 0.12 has just been released! Checkout the <a href='https://blog.holoviz.org/posts/hvplot_release_0.12/'>blog post</a> and support hvPlot by giving it a 🌟 on <a href='https://github.com/holoviz/hvplot'>Github</a>.",  # noqa: E501
         'switcher': {
             'json_url': 'https://hvplot.holoviz.org/switcher.json',
             'version_match': switcher_version,
@@ -83,7 +85,7 @@
 html_logo = '_static/logo_horizontal.svg'
 html_favicon = '_static/favicon.ico'
 
-extensions += [  # noqa
+extensions += [  # noqa: F405
     'sphinx.ext.autosummary',
     'nbsite.gallery',
     'nbsite.analytics',
@@ -175,7 +177,7 @@
 
 html_extra_path = ['topics.html']
 
-html_context.update(  # noqa
+html_context.update(  # noqa: F405
     {
         'last_release': f'v{release}',
         'default_mode': 'light',
@@ -216,7 +218,7 @@
             'reference/tabular/lagplot': 'ref/api/manual/hvplot.plotting.lag_plot',
             'reference/tabular/line': 'ref/api/manual/hvplot.hvPlot.line',
             'reference/tabular/ohlc': 'ref/api/manual/hvplot.hvPlot.ohlc',
-            'reference/tabular/parallelcoordinates': 'ref/api/manual/hvplot.plotting.parallel_coordinates',
+            'reference/tabular/parallelcoordinates': 'ref/api/manual/hvplot.plotting.parallel_coordinates',  # noqa: E501
             'reference/tabular/scatter': 'ref/api/manual/hvplot.hvPlot.scatter',
             'reference/tabular/scattermatrix': 'ref/api/manual/hvplot.plotting.scatter_matrix',
             'reference/tabular/step': 'ref/api/manual/hvplot.hvPlot.step',
@@ -294,7 +296,7 @@
 }
 
 # To avoid this warning
-# hvplot/ui.py:docstring of hvplot.ui.hvPlotExplorer:43: WARNING: autosummary: stub file not found 'hvplot.ui.hvPlotExplorer.hvplot'. Check your autosummary_generate setting.
+# hvplot/ui.py:docstring of hvplot.ui.hvPlotExplorer:43: WARNING: autosummary: stub file not found 'hvplot.ui.hvPlotExplorer.hvplot'. Check your autosummary_generate setting.  # noqa: E501
 # See https://stackoverflow.com/a/73294408
 numpydoc_class_members_toctree = False
 

doc/conftest.py

@@ -1,11 +1,10 @@
 import os
-
 from importlib.util import find_spec
 
 import dask
-
-from packaging.version import Version, parse
 from bokeh.io.webdriver import webdriver_control
+from packaging.version import Version, parse
+
 from hvplot.util import _PD_GE_3_0_0
 
 # Examples that are slow to run and/or download large files.
@@ -57,8 +56,8 @@
     collect_ignore_glob += ['ref/data_libraries.ipynb']
 
 try:
-    import ibis
     import duckdb
+    import ibis
 
     # 'Ibis <= 10.8.0 is incompatible with DuckDB >= 1.4')
     if parse(ibis.__version__) <= parse('10.8.0') and parse(duckdb.__version__) >= parse('1.4'):
@@ -81,13 +80,13 @@
 pygraphviz = None
 
 try:
-    import pygraphviz  # noqa
+    import pygraphviz
 except ImportError:
     pass
 
 pydot = None
 try:
-    import pydot  # noqa
+    import pydot
 except ImportError:
     pass
 

doc/gallery/big-data/large_vectorfield_downsampled.ipynb

@@ -65,13 +65,13 @@
    "source": [
     "def downsample_quiver(x_range=None, y_range=None, nmax=10):\n",
     "    \"\"\"\n",
-    "    Creates a HoloViews vector field plot from a dataset, dynamically downsampling \n",
+    "    Creates a HoloViews vector field plot from a dataset, dynamically downsampling\n",
     "    data based on the visible range to optimize memory usage.\n",
     "\n",
     "    Args:\n",
     "        x_range (tuple, optional): Range of x values to include. Defaults to None (full range).\n",
     "        y_range (tuple, optional): Range of y values to include. Defaults to None (full range).\n",
-    "        nmax (int, optional): Maximum number of points along each axis after coarsening. \n",
+    "        nmax (int, optional): Maximum number of points along each axis after coarsening.\n",
     "                              Defaults to 10.\n",
     "\n",
     "    Returns:\n",

doc/gallery/categorical/category_heatmap.ipynb

@@ -27,7 +27,7 @@
     "    y='depth_class',\n",
     "    C='mag',\n",
     "    reduce_function=np.size,\n",
-    "    fields={'mag': 'count'},  # for the tooltip to display count instead of mag \n",
+    "    fields={'mag': 'count'},  # for the tooltip to display count instead of mag\n",
     "    logz=True,\n",
     "    title='Category Heatmap (Bokeh)',\n",
     "    xlabel='Magnitude Class',\n",
@@ -53,7 +53,7 @@
     "    y='depth_class',\n",
     "    C='mag',\n",
     "    reduce_function=np.size,\n",
-    "    fields={'mag': 'count'},  # for the tooltip to display count instead of mag \n",
+    "    fields={'mag': 'count'},  # for the tooltip to display count instead of mag\n",
     "    logz=True,\n",
     "    title='Category Heatmap (Matplotlib)',\n",
     "    xlabel='Magnitude Class',\n",

doc/gallery/categorical/lollipop_plot.ipynb

@@ -29,7 +29,7 @@
     "\n",
     "# Create line segments for each stem\n",
     "segments = hv.Segments(\n",
-    "    [(xv, 0, xv, yv) for xv, yv in zip(df['type'], df['value'])]\n",
+    "    [(xv, 0, xv, yv) for xv, yv in zip(df['type'], df['value'], strict=True)]\n",
     ").opts(line_width=4, color='lightgrey')\n",
     "# Markers at the top\n",
     "markers = df.hvplot.scatter(x='type', y='value', size=200)\n",
@@ -61,7 +61,7 @@
     "\n",
     "# Create line segments for each stem\n",
     "segments = hv.Segments(\n",
-    "    [(xv, 0, xv, yv) for xv, yv in zip(df['type'], df['value'])]\n",
+    "    [(xv, 0, xv, yv) for xv, yv in zip(df['type'], df['value'], strict=True)]\n",
     ").opts(linewidth=4, color='lightgrey')\n",
     "# Markers at the top\n",
     "markers = df.hvplot.scatter(x='type', y='value').opts(s=250)\n",

doc/ref/api/manual/hvplot.hvPlot.bar.ipynb

@@ -98,7 +98,10 @@
     "}).set_index(['Project', 'Source'])\n",
     "print(multi_index_df.head(3))\n",
     "\n",
-    "multi_index_df.hvplot.bar(title='Project downloads (stacked multi-index)', stacked=True, yformatter='%i')"
+    "multi_index_df.hvplot.bar(\n",
+    "    title='Project downloads (stacked multi-index)',\n",
+    "    stacked=True, yformatter='%i'\n",
+    ")"
    ]
   },
   {

doc/ref/api/manual/hvplot.hvPlot.barh.ipynb

@@ -103,7 +103,7 @@
     "    stacked=True,\n",
     "    width=500,\n",
     "    legend='bottom_right',\n",
-    "    xformatter='%i', \n",
+    "    xformatter='%i',\n",
     ")"
    ]
   },