feat(Sensors): Add search filter to sensor setting allow list dialog by danielgomezrico · Pull Request #6567 · home-assistant/android

danielgomezrico · 2026-03-12T19:40:32Z

Summary

Add a search TextField to SensorDetailSettingDialog so users can quickly filter long app lists (e.g., Last Notification Allow List)
Filtering is local to the composable — no ViewModel changes, selections persist across searches
Works for all list-type sensor settings (LIST_APPS, LIST_BLUETOOTH, LIST_ZONES, etc.)

Checklist

New or updated tests have been added to cover the changes following the testing guidelines.
The code follows the project's code style and best_practices.
The changes have been thoroughly tested, and edge cases have been considered.
Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Screenshots

Before

No search bar, hard to read and search:

After

Copilot

Pull request overview

Adds an in-dialog search field to SensorDetailSettingDialog so users can locally filter long list-type sensor setting entries (apps, Bluetooth devices, zones, etc.) without changing ViewModel/state handling.

Changes:

Added a search TextField with clear button to filter list-type setting dialog entries.
Introduced filterSettingEntries(...) helper to apply case-insensitive filtering.
Added unit tests covering filtering behavior and edge cases.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt	Adds search UI + filtering logic for list dialogs; introduces `filterSettingEntries` helper
app/src/test/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailSettingDialogFilterTest.kt	Adds JUnit tests validating filtering behavior

You can also share your feedback on Copilot code review. Take the survey.

jpelgrom · 2026-03-13T20:14:13Z

Can you provide screenshots for the change?

Did you consider only showing search when there is a long list? Showing search when there are only 3 items is a bit weird.

This dialog isn't really suited for a large list anyway, I wonder if it should be changed to a different picker like the bottom sheet/dialog we have implemented for entities recently.

Both comments generated by Copilot are valid, please address them (try doing it yourself without AI to understand the change you're making).

Add a search TextField to `SensorDetailSettingDialog` so users can quickly find apps in long lists (e.g., Last Notification Allow List). Filtering is local to the composable; selections persist across searches.

danielgomezrico · 2026-03-13T22:52:54Z

Can you provide screenshots for the change?

Sure! updated.

Did you consider only showing search when there is a long list? Showing search when there are only 3 items is a bit weird.

Oh that Idea is cool I will adapt it for that case

This dialog isn't really suited for a large list anyway, I wonder if it should be changed to a different picker like the
bottom sheet/dialog we have implemented for entities recently.

It makes total sense, but in the mean while it would help, the list of apps could be pretty long and having to search in that dialog is pretty hard.

… lists Show search only when entries > 10. Extract SettingSearchField composable for readability.

TimoPtr · 2026-03-16T09:15:39Z

I'm aligned with @jpelgrom I would prefer to see a bottom sheet here. You already have the needed components to do so. You can check the Entity picker like @jpelgrom suggested.

You might also want to merge main in your branch since we've fixed some issue with ktlint recently.

danielgomezrico · 2026-03-17T00:03:58Z

I'm aligned with @jpelgrom I would prefer to see a bottom sheet here. You already have the needed components to do so. You can check the Entity picker like @jpelgrom suggested.

You might also want to merge main in your branch since we've fixed some issue with ktlint recently.

Got it, Ill check if I can make it for this case.

One thing I've noticed is that these types of dialogs are used in other places; should the bottom sheet be limited to this case?

jpelgrom · 2026-03-17T06:31:52Z

One thing I've noticed is that these types of dialogs are used in other places; should the bottom sheet be limited to this case?

Just this specific dialog, with a long list of apps that you may want to search. Replacing all other dialogs makes this PR too big and also doesn't make sense as a pattern when there are only 2-3 options.

danielgomezrico · 2026-03-24T00:18:10Z

@jpelgrom @TimoPtr I made the update to show it in a bottom sheet, WDYT?

TimoPtr · 2026-03-25T13:34:57Z

@danielgomezrico could you address the lint issue and when you are ready put the PR in ready for review.

Ktlint function-signature rule requires single-line when signature fits within max_line_length (120 chars).

danielgomezrico · 2026-04-06T19:45:18Z

@TimoPtr can you help me aproving the CI 🙏🏻 ?

TimoPtr

The UX needs to be adjust the rest of the comments are mostly to adjust with the project guidelines.

home-assistant · 2026-04-13T13:44:50Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

- Extract HASearchField to :common, replacing duplicated search fields in EntityPicker and SensorDetailSettingSheet - Replace rememberStandardBottomSheetState (intended for BottomSheetScaffold) with rememberModalBottomSheetState(skipPartiallyExpanded = true) so the sheet no longer blinks before fully expanding; drop the LaunchedEffect.expand() workaround - Extract parseSettingLabel helper used by both BottomSheetSettingRow and SensorDetailSettingRow - Rename consumeFlingNestedScrollConnection to nestedScrollFlingGuard, demote rememberFilteredSettingEntries to private, and simplify the row toggle logic

…ate immutability - joinSelectedValues: pin behavior on empty/single/multi values, bracket stripping (bug-for-bug parity with legacy code), and unicode pass-through - parseSettingLabel: split semantics, parens stripping, multi-newline limit, and edge cases - SettingDialogState immutability: prove state.copy(setting = setting.copy(...)) produces a new SensorSetting and leaves the original instance untouched

Verifies that empty queries propagate immediately while non-empty queries are delayed by the configured debounce, that rapid updates coalesce to the latest value, and that cancellation drops pending emissions.

…-allow-list # Conflicts: # app/src/main/kotlin/io/homeassistant/companion/android/util/compose/entity/EntityPicker.kt

ktlint function-signature rule prefers single-line when within max line length.

…bleForTesting

…bleForTesting - Wrap setting entries in `@Immutable SettingEntries` data class at the composable boundary so the Compose Compiler can infer parameter stability for `rememberFilteredSettingEntries` (lint id 6307/6309). - Drop `@VisibleForTesting` from `parseSettingLabel`; it is genuinely shared production helper consumed by `SensorDetailView.kt` (lint id 6306/6308). Function stays `internal`. - Add `SettingEntriesTest` exercising the new wrapper so a future regression of the stability fix fails loudly.

danielgomezrico · 2026-05-08T20:40:41Z

@TimoPtr friendly ping

TimoPtr

I don't like the UI when applying the search

The sheet should resize not leave blanks like this. Also the colors seems off, probably a missing theme applied somewhere.

TimoPtr · 2026-05-12T12:13:50Z

+    dispatcher: CoroutineContext = Dispatchers.Default,
+) {
+    val checkedValue = remember {
+        mutableStateListOf<String>().also { it.addAll(state.entriesSelected) }


Suggested change

mutableStateListOf<String>().also { it.addAll(state.entriesSelected) }

state.entriesSelected.toMutableStateList()

TimoPtr · 2026-05-12T12:19:23Z

+                    SensorSettingType.LIST_BEACONS,
                )
+                if (isMultiSelectList) {
+                    SensorDetailSettingSheet(


You should add a HATheme here and add a todo tight to #6839

TimoPtr · 2026-05-12T12:28:31Z

+        bottomSheetState = bottomSheetState,
+        modifier = modifier,
+        onDismissRequest = onDismiss,
+    ) {


Break down the content into multiple smaller composables

TimoPtr · 2026-05-12T12:30:13Z

+                    horizontal = HADimens.SPACE4,
+                    vertical = HADimens.SPACE3,


I think you could apply this directly to the Column using the horizontal and vertical params.

TimoPtr · 2026-05-12T12:33:20Z

+ * recompositions.
+ */
+@Immutable
+internal data class SettingEntries(val items: List<Pair<String, String>>)


Let's not ever work with a Pair<String, String> it is not usable if you don't know how it has been built. No need to build a wrapper arround the list for the immutable annotation, for now ignore the lint warning. We should one day use Immutable containers but we are not yet ready for it.

TimoPtr · 2026-05-12T12:34:59Z

+    var filtered by remember(entries) { mutableStateOf(entries.items) }
+
+    LaunchedEffect(entries, searchQuery) {
+        filtered = withContext(dispatcher) {


Let's not bother with a parameters for the Dispatcher here and always use Default.

Copilot AI review requested due to automatic review settings March 12, 2026 19:40

home-assistant Bot added the cla-signed label Mar 12, 2026

Copilot started reviewing on behalf of danielgomezrico March 12, 2026 19:41 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Comment thread ...src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt Outdated

Comment thread ...src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt Outdated

feat(sensors): add search filter to sensor setting allow list dialog

2baef1b

Add a search TextField to `SensorDetailSettingDialog` so users can quickly find apps in long lists (e.g., Last Notification Allow List). Filtering is local to the composable; selections persist across searches.

danielgomezrico force-pushed the feature/search-sensor-allow-list branch from 41b5f66 to 2baef1b Compare March 13, 2026 22:51

danielgomezrico changed the title ~~feat(sensors): add search filter to sensor setting allow list dialog~~ feat(Sensors): Add search filter to sensor setting allow list dialog Mar 13, 2026

github-advanced-security AI found potential problems Mar 13, 2026

View reviewed changes

refactor(sensors): extract search field composable and hide for small…

6fdce1a

… lists Show search only when entries > 10. Extract SettingSearchField composable for readability.

github-advanced-security AI found potential problems Mar 13, 2026

View reviewed changes

TimoPtr marked this pull request as draft March 16, 2026 09:15

Update dialog

f015d0c

github-advanced-security AI found potential problems Mar 24, 2026

View reviewed changes

danielgomezrico added 3 commits March 29, 2026 08:31

fix(sensors): sort imports in lexicographic order for ktlint

65d0321

chore(UI): Use styles to present better data on the UI

efcacd9

style(Sensors): Add braces to if/else in filterSettingEntries

0c07286

danielgomezrico marked this pull request as ready for review March 29, 2026 14:02

github-advanced-security AI found potential problems Mar 29, 2026

View reviewed changes

TimoPtr marked this pull request as draft March 30, 2026 08:01

style(Sensors): Convert short function signatures to single-line format

ec55766

Ktlint function-signature rule requires single-line when signature fits within max_line_length (120 chars).

danielgomezrico marked this pull request as ready for review April 2, 2026 23:51

TimoPtr reviewed Apr 13, 2026

View reviewed changes

Comment thread ...src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt Outdated

TimoPtr reviewed Apr 13, 2026

View reviewed changes

Comment thread ...src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt

TimoPtr reviewed Apr 13, 2026

View reviewed changes

Comment thread ...src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt Outdated

TimoPtr reviewed Apr 13, 2026

View reviewed changes

Comment thread ...src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt Outdated

TimoPtr requested changes Apr 13, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft April 13, 2026 13:44

danielgomezrico added 5 commits May 2, 2026 09:21

Cleanup

b38107c

test(Sensors): rename filter test to match SensorDetailSettingSheet

271dca3

test(common): cover HASearchField debounce behaviour

5f03e84

Verifies that empty queries propagate immediately while non-empty queries are delayed by the configured debounce, that rapid updates coalesce to the latest value, and that cancellation drops pending emissions.

danielgomezrico requested a review from TimoPtr May 4, 2026 02:34

danielgomezrico added 2 commits May 3, 2026 21:40

Merge remote-tracking branch 'origin/main' into feature/search-sensor…

9e50c02

…-allow-list # Conflicts: # app/src/main/kotlin/io/homeassistant/companion/android/util/compose/entity/EntityPicker.kt

style(common): collapse debouncedSearchUpdate signature to single line

1182eee

ktlint function-signature rule prefers single-line when within max line length.

github-advanced-security AI found potential problems May 4, 2026

View reviewed changes

danielgomezrico marked this pull request as ready for review May 4, 2026 18:19

TimoPtr requested changes May 12, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft May 12, 2026 12:11

TimoPtr reviewed May 12, 2026

View reviewed changes

danielgomezrico had a problem deploying to ui-test May 12, 2026 12:17 — with GitHub Actions Failure

TimoPtr reviewed May 12, 2026

View reviewed changes

	mutableStateListOf<String>().also { it.addAll(state.entriesSelected) }
	state.entriesSelected.toMutableStateList()

Uh oh!

Conversation

danielgomezrico commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Screenshots

Before

After

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

jpelgrom commented Mar 13, 2026

Uh oh!

danielgomezrico commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TimoPtr commented Mar 16, 2026

Uh oh!

danielgomezrico commented Mar 17, 2026

Uh oh!

jpelgrom commented Mar 17, 2026

Uh oh!

danielgomezrico commented Mar 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TimoPtr commented Mar 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danielgomezrico commented Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TimoPtr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danielgomezrico commented Mar 12, 2026 •

edited

Loading

danielgomezrico commented Mar 13, 2026 •

edited

Loading