Remove the icon for notification actions#6821
Conversation
The icon only shows on Android Auto and in the Head's Up view, completely replaces the action title.
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
There was a problem hiding this comment.
Pull request overview
This PR adjusts how notification action buttons are built so that action titles remain visible (not replaced by an icon) in Android Auto and heads-up notifications.
Changes:
- Remove the icon from “regular” notification actions by building the action with a
nullicon.
ChadKillingsworth
had a problem deploying
to
ui-test
GitHub Actions
Failure
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I'm concerned that wear OS requires an icon and that this change, while beneficial to Android Auto, will negatively impact watches. |
Wear OS 3+ doesn't show notification action icons in the default and Samsung skins as far as I'm aware. Is there a specific reason for your concern? |
ChadKillingsworth
had a problem deploying
to
ui-test
GitHub Actions
Failure
|
My concern was just unfamiliarity with that device type and light research on the subject. |
|
Sorry for the delay. Tested with Android Auto and Wear OS, as well as a 'normal' device, and the change looks good. Could you rebase the branch or merge the latest changes so we can get CI to pass? The "Instrumentation Test app" check will currently fail but was recently fixed for forks. |
Summary
The icon only shows on Android Auto and in the Head's Up view, completely replaces the action title.
After the change, the action title correctly shows up:
Local testing demonstrated that setting a custom icon as requested in #6736 had the same effect as setting the icon to
null- the custom icon did not show.Checklist
Screenshots
See screenshots above. The change should have no effect between light and dark mode.
Link to pull request in documentation repositories
Because custom icons were not supported already, no changes to documentation should be needed.