Skip to content

Revert "Add Remote platform to SMLIGHT Integration (#166728)"#167424

Merged
joostlek merged 1 commit into
home-assistant:devfrom
tl-sl:revert-remote
Apr 6, 2026
Merged

Revert "Add Remote platform to SMLIGHT Integration (#166728)"#167424
joostlek merged 1 commit into
home-assistant:devfrom
tl-sl:revert-remote

Conversation

@tl-sl
Copy link
Copy Markdown
Contributor

@tl-sl tl-sl commented Apr 5, 2026

Proposed change

This reverts commit 12b485b.

Reverts the recently added Remote platform for SMLIGHT integration, that probably should not have been merged ;)
We are going to implement Infrared platform instead.

This only exists on dev branch and hasnt been released to users.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 5, 2026 08:26
@home-assistant home-assistant Bot added cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: smlight remove-platform small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage by-code-owner Quality Scale: silver labels Apr 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the Remote platform that was recently added to the SMLIGHT integration. The Remote platform was added as part of a feature to support infrared capabilities on SLZB-Ultima devices, but the implementation is being rolled back to be reimplemented as an Infrared platform instead. Since this feature only exists on the dev branch and hasn't been released to users, the revert is safe.

Changes:

  • Removed the Remote platform implementation file (remote.py)
  • Removed Remote platform from the PLATFORMS list in __init__.py
  • Removed Remote entity strings and the send_ir_code_failed error message from strings.json
  • Removed all Remote platform tests

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
homeassistant/components/smlight/__init__.py Removed Platform.REMOTE from PLATFORMS list
homeassistant/components/smlight/strings.json Removed Remote entity translation strings and error message
homeassistant/components/smlight/remote.py Deleted entire Remote platform implementation
tests/components/smlight/test_remote.py Deleted entire Remote platform test file

Copy link
Copy Markdown
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to revert the documentation pull request as well.

@joostlek joostlek merged commit 67243a5 into home-assistant:dev Apr 6, 2026
36 of 37 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: smlight Quality Scale: silver remove-platform small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants