Fix missing color_mode initialization in MQTT JSON light schema by noerstad · Pull Request #167429 · home-assistant/core

noerstad · 2026-04-05T11:13:44Z

Proposed change

PR #162715 changed _attr_color_mode default from ColorMode.UNKNOWN to None and added a strict check that raises HomeAssistantError when a light is on but color_mode is None. The template schema (schema_template.py) was updated to initialize _attr_color_mode = ColorMode.UNKNOWN before the color mode branching logic, but the JSON schema (schema_json.py) was not.

This causes MQTT JSON schema lights to fail with:

does not report a color mode

This PR initializes _attr_color_mode = ColorMode.UNKNOWN before the color mode branching in _setup_from_config, and removes the unused _fixed_color_mode class variable.

Type of change

Bugfix (non-breaking change which fixes an issue)

Additional information

This PR is related to issue: Raise on missing color mode #162715 (Raise on missing color mode)
The template schema received the safety net in Raise on missing color mode #162715, the JSON schema did not

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
There is no commented out code in this PR.
I have followed the development checklist
Tests have been added to verify that the new code works.

home-assistant

Hi @noerstad

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2026-04-05T11:13:51Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

home-assistant · 2026-04-05T11:13:54Z

Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

Fixes MQTT JSON schema lights failing with “does not report a color mode” by aligning schema_json.py with the safety-net initialization approach already used in the template schema.

Changes:

Initialize _attr_color_mode to ColorMode.UNKNOWN during setup to avoid None when the entity is on.
Introduce _fixed_color_mode assignment for single supported-color-mode configurations.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Stale

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

jbouwh

Thanks! As a fix only the assignment to an unknown color should be needed. The rest of the changes can be removed. The test is okay.

diff --git a/homeassistant/components/mqtt/light/schema_json.py b/homeassistant/components/mqtt/light/schema_json.py
index 111b176cb01..b388cdebb65 100644
--- a/homeassistant/components/mqtt/light/schema_json.py
+++ b/homeassistant/components/mqtt/light/schema_json.py
@@ -146,7 +146,6 @@ class MqttLightJson(MqttEntity, LightEntity, RestoreEntity):
     _entity_id_format = ENTITY_ID_FORMAT
     _attributes_extra_blocked = MQTT_LIGHT_ATTRIBUTES_BLOCKED
 
-    _fixed_color_mode: ColorMode | str | None = None
     _flash_times: dict[str, int | None]
     _topic: dict[str, str | None]
     _optimistic: bool
@@ -190,13 +189,11 @@ class MqttLightJson(MqttEntity, LightEntity, RestoreEntity):
         self._attr_supported_features |= (
             config[CONF_TRANSITION] and LightEntityFeature.TRANSITION
         )
-        self._fixed_color_mode = None
         self._attr_color_mode = ColorMode.UNKNOWN
         if supported_color_modes := self._config.get(CONF_SUPPORTED_COLOR_MODES):
             self._attr_supported_color_modes = supported_color_modes
             if self.supported_color_modes and len(self.supported_color_modes) == 1:
-                self._fixed_color_mode = next(iter(self.supported_color_modes))
-                self._attr_color_mode = self._fixed_color_mode
+                self._attr_color_mode = next(iter(self.supported_color_modes))
             else:
                 self._attr_color_mode = ColorMode.UNKNOWN
         elif config.get(CONF_BRIGHTNESS):
@@ -209,7 +206,7 @@ class MqttLightJson(MqttEntity, LightEntity, RestoreEntity):
             self._attr_color_mode = ColorMode.ONOFF
 
     def _update_color(self, values: dict[str, Any]) -> None:
-        color_mode: str = self._fixed_color_mode or values["color_mode"]
+        color_mode: str = values["color_mode"]
         if not self._supports_color_mode(color_mode):
             _LOGGER.warning(
                 "Invalid color mode '%s' received for entity %s",
@@ -340,12 +337,8 @@ class MqttLightJson(MqttEntity, LightEntity, RestoreEntity):
             self._attr_brightness = last_attributes.get(
                 ATTR_BRIGHTNESS, self.brightness
             )
-            self._attr_color_mode = cast(
-                ColorMode,
-                self._fixed_color_mode
-                if self._fixed_color_mode is not None
-                else last_attributes.get(ATTR_COLOR_MODE, self.color_mode)
-                or ColorMode.UNKNOWN,
+            self._attr_color_mode = last_attributes.get(
+                ATTR_COLOR_MODE, self.color_mode
             )
             self._attr_color_temp_kelvin = last_attributes.get(
                 ATTR_COLOR_TEMP_KELVIN, self.color_temp_kelvin

jbouwh · 2026-04-06T15:50:00Z

Looks good, please do no rewrite/replace previous commits

jbouwh · 2026-04-06T16:41:37Z

If you are ready please mark the PR "Ready for review"

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Initialize `_attr_color_mode` to `ColorMode.UNKNOWN` before the color mode branching logic in `_setup_from_config`, matching the pattern already used in `schema_template.py` (added in home-assistant#162715). Without this, `_attr_color_mode` can remain `None` (the new default from home-assistant#162715) in edge cases during entity (re)setup, causing "does not report a color mode" errors when the light is on. Also removes the unused `_fixed_color_mode` class variable.

jbouwh · 2026-04-06T19:11:17Z

Please do not force push

jbouwh · 2026-04-06T19:14:46Z

~~Can you please update the PR description, so that it matches the change?~~

Not needed anymore

jbouwh

Thanks @noerstad for your first contribution 👍

jbouwh · 2026-04-06T20:45:01Z

@noerstad Please mark the PR ready so that it can be merged

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 5, 2026 11:13

noerstad requested review from bdraco, emontnemery and jbouwh as code owners April 5, 2026 11:13

home-assistant Bot previously requested changes Apr 5, 2026

View reviewed changes

home-assistant Bot added bugfix cla-needed core integration: mqtt small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage labels Apr 5, 2026

home-assistant Bot marked this pull request as draft April 5, 2026 11:13

home-assistant Bot assigned emontnemery, jbouwh and bdraco Apr 5, 2026

home-assistant Bot added the Quality Scale: platinum label Apr 5, 2026

Copilot started reviewing on behalf of noerstad April 5, 2026 11:14 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

Comment thread homeassistant/components/mqtt/light/schema_json.py Outdated

Comment thread homeassistant/components/mqtt/light/schema_json.py

home-assistant Bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Apr 5, 2026

noerstad force-pushed the fix/mqtt-json-light-color-mode branch from b674b04 to 1a9e273 Compare April 5, 2026 11:45

noerstad requested a review from Copilot April 5, 2026 11:48

Copilot started reviewing on behalf of noerstad April 5, 2026 11:49 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

Comment thread homeassistant/components/mqtt/light/schema_json.py Outdated

Copilot started reviewing on behalf of noerstad April 5, 2026 14:56 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

jbouwh requested changes Apr 6, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft April 6, 2026 14:44

jbouwh added this to the 2026.4.2 milestone Apr 6, 2026

noerstad force-pushed the fix/mqtt-json-light-color-mode branch from 630b4de to 661e240 Compare April 6, 2026 15:46

jbouwh requested changes Apr 6, 2026

View reviewed changes

Comment thread tests/components/mqtt/test_light_json.py Outdated

Comment thread tests/components/mqtt/test_light_json.py Outdated

Comment thread tests/components/mqtt/test_light_json.py Outdated

Copilot AI review requested due to automatic review settings April 6, 2026 16:51

noerstad force-pushed the fix/mqtt-json-light-color-mode branch from 661e240 to c6ba343 Compare April 6, 2026 16:51

Copilot started reviewing on behalf of noerstad April 6, 2026 16:52 View session

jbouwh requested changes Apr 6, 2026

View reviewed changes

Comment thread tests/components/mqtt/test_light_json.py

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Comment thread tests/components/mqtt/test_light_json.py

noerstad force-pushed the fix/mqtt-json-light-color-mode branch from c6ba343 to f473c15 Compare April 6, 2026 19:09

jbouwh approved these changes Apr 6, 2026

View reviewed changes

home-assistant Bot added the code-owner-approved label Apr 6, 2026

noerstad marked this pull request as ready for review April 7, 2026 06:56

Copilot AI review requested due to automatic review settings April 7, 2026 06:56

home-assistant Bot requested a review from jbouwh April 7, 2026 06:56

Copilot started reviewing on behalf of noerstad April 7, 2026 06:57 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

jbouwh merged commit 74a6f78 into home-assistant:dev Apr 7, 2026
50 of 51 checks passed

github-actions Bot locked and limited conversation to collaborators Apr 8, 2026

frenck added the cherry-picked label Apr 10, 2026

Uh oh!

Conversation

noerstad commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant Bot commented Apr 5, 2026

Uh oh!

home-assistant Bot commented Apr 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jbouwh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbouwh commented Apr 6, 2026

Uh oh!

jbouwh commented Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jbouwh commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbouwh commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbouwh left a comment

Choose a reason for hiding this comment

Uh oh!

jbouwh commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

noerstad commented Apr 5, 2026 •

edited

Loading

jbouwh commented Apr 6, 2026 •

edited

Loading

jbouwh commented Apr 6, 2026 •

edited

Loading