Bump jvcprojector dependency to pyjvcprojector 2.0.5#167450
Conversation
|
Hey there @msavazzi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR updates Home Assistant’s jvc_projector integration dependency pin to pyjvcprojector==2.0.5 to incorporate upstream fixes (notably the missing command value fix referenced in the upstream issue).
Changes:
- Bump
pyjvcprojectorfrom2.0.3to2.0.5in the integration manifest. - Update generated requirement lockfiles (
requirements_all.txt,requirements_test_all.txt) to match the new pin.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/jvc_projector/manifest.json |
Updates the integration’s runtime dependency pin to pyjvcprojector==2.0.5. |
requirements_all.txt |
Updates the global requirements pin for the integration to 2.0.5. |
requirements_test_all.txt |
Updates the test requirements pin for the integration to 2.0.5. |
|
Any reason you still have #167449 open? I don't see any code changes on the HA side, so this PR should be sufficient. |
|
Wasn't sure if the core devs would reject because each version bump has a different associated diff. Likely overkill but I am often asked to split up PRs, so trying to be proactive. |
|
But agree its kinda silly. Went ahead and closed the other one. |
|
Yeah, it's not too big of a concern for dependency changes. Only exception is if the API change breaks something and other changes need to happen with the bump. Otherwise, you can jump directly to any version as you please. |
Proposed change
Bump jvcprojector dependency to pyjvcprojector 2.0.5. Fixes missing command value for certain projectors. Reported in SteveEasley/pyjvcprojector#9.
SteveEasley/pyjvcprojector@v2.0.3...v2.0.5
Should merge this first #167449
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: