Skip to content

Bump jvcprojector dependency to pyjvcprojector 2.0.5#167450

Merged
joostlek merged 1 commit into
home-assistant:devfrom
SteveEasley:pyjvcprojector2.0.5
Apr 6, 2026
Merged

Bump jvcprojector dependency to pyjvcprojector 2.0.5#167450
joostlek merged 1 commit into
home-assistant:devfrom
SteveEasley:pyjvcprojector2.0.5

Conversation

@SteveEasley
Copy link
Copy Markdown
Contributor

@SteveEasley SteveEasley commented Apr 5, 2026

Proposed change

Bump jvcprojector dependency to pyjvcprojector 2.0.5. Fixes missing command value for certain projectors. Reported in SteveEasley/pyjvcprojector#9.

SteveEasley/pyjvcprojector@v2.0.3...v2.0.5

Should merge this first #167449

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 5, 2026 16:00
@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: jvc_projector small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Apr 5, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Apr 5, 2026

Hey there @msavazzi, mind taking a look at this pull request as it has been labeled with an integration (jvc_projector) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jvc_projector can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign jvc_projector Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Home Assistant’s jvc_projector integration dependency pin to pyjvcprojector==2.0.5 to incorporate upstream fixes (notably the missing command value fix referenced in the upstream issue).

Changes:

  • Bump pyjvcprojector from 2.0.3 to 2.0.5 in the integration manifest.
  • Update generated requirement lockfiles (requirements_all.txt, requirements_test_all.txt) to match the new pin.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/jvc_projector/manifest.json Updates the integration’s runtime dependency pin to pyjvcprojector==2.0.5.
requirements_all.txt Updates the global requirements pin for the integration to 2.0.5.
requirements_test_all.txt Updates the test requirements pin for the integration to 2.0.5.

@SteveEasley SteveEasley changed the title Bump dependency to pyjvcprojector 2.0.5 Bump jvcprojector dependency to pyjvcprojector 2.0.5 Apr 5, 2026
@noahhusby
Copy link
Copy Markdown
Contributor

noahhusby commented Apr 5, 2026

Any reason you still have #167449 open?

I don't see any code changes on the HA side, so this PR should be sufficient.

@SteveEasley
Copy link
Copy Markdown
Contributor Author

Wasn't sure if the core devs would reject because each version bump has a different associated diff. Likely overkill but I am often asked to split up PRs, so trying to be proactive.

@SteveEasley
Copy link
Copy Markdown
Contributor Author

But agree its kinda silly. Went ahead and closed the other one.

@noahhusby
Copy link
Copy Markdown
Contributor

Yeah, it's not too big of a concern for dependency changes. Only exception is if the API change breaks something and other changes need to happen with the bump. Otherwise, you can jump directly to any version as you please.

@joostlek joostlek merged commit b1d8153 into home-assistant:dev Apr 6, 2026
50 of 51 checks passed
@joostlek joostlek added this to the 2026.4.2 milestone Apr 6, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants