Add description for vacuum segments_changed repair issue#167463
Add description for vacuum segments_changed repair issue#167463JamieMagee wants to merge 1 commit into
Conversation
The segments_changed issue was created with an empty description, but non-fixable issues require a description translation. This caused test failures in the translation validation framework.
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a translation-validation failure in the vacuum integration by ensuring the non-fixable segments_changed repair issue includes a non-empty description in strings.json (empty strings are stripped during translation compilation).
Changes:
- Add a user-facing description for the
segments_changedrepair issue to prevent the translation key from being stripped at build time.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/vacuum/strings.json | Adds a non-empty description for the segments_changed repair issue translation. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
arturpragacz
left a comment
There was a problem hiding this comment.
This change doesn't look correct. What problem does it solve? Is it AI generated?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
@arturpragacz This test fails on dev right now. You can reproduce it with: The We ran into this while going through the nixpkgs Home Assistant test suite, where the ecovacs, roborock, and vacuum component tests all fail on this. (We've been carrying them as ignored tests: https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/home-assistant/tests.nix) I wrote the description text. If you'd rather handle it differently (make the issue fixable, or change the test framework to allow empty descriptions), happy to go that route instead. |
|
I cannot reproduce the test failure locally. It also does not fail in our CI. The |
|
@arturpragacz The issue only shows up when compiled translations are present. Apologies, I skipped that step earlier:
The develop script preserves the empty string so tests pass locally, but the Lokalise export strips it, which is what ends up in the sdist. |
|
Better solution: #167928. |
Proposed change
The
segments_changedrepair issue has an emptydescriptionfield instrings.json. The issue is created withis_fixable=False, and the test framework requires non-fixable issues to have a description translation. Empty strings get stripped during translation compilation, so the key is missing at runtime and the translation validation fails.Added a description explaining what changed and what the user should check.
Type of change
Additional information
Checklist
ruff format homeassistant tests)To help with the load of incoming pull requests: