Add descriptions for sensor statistics repair issues#167464
Closed
JamieMagee wants to merge 1 commit into
Closed
Conversation
home-assistant
Bot
added
bugfix
cla-signed
core
integration: sensor
small-pr
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes translation validation failures in the Sensor integration by adding missing repair issue descriptions for non-fixable statistics-related issues.
Changes:
- Add non-empty
descriptionstrings for theunits_changed,state_class_removed, andmean_type_changedrepair issues. - Use existing placeholders passed from
homeassistant/components/sensor/recorder.pyto populate the new descriptions.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/sensor/strings.json |
Adds repair issue descriptions so translation compilation/validation includes required keys for non-fixable issues. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
The units_changed, state_class_removed, and mean_type_changed issues were created with empty descriptions, but non-fixable issues require a description translation. This caused test failures in the translation validation framework.
JamieMagee
force-pushed
the
fix-sensor-issue-descriptions
branch
from
f26573e to
3275f24
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes translation validation failures in the Sensor integration by adding missing description strings for non-fixable statistics-related repair issues.
Changes:
- Add description text for the
mean_type_changedissue. - Add description text for the
state_class_removedissue. - Add description text for the
units_changedissue, using existing placeholders provided byrecorder.py.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/sensor/strings.json |
Adds non-empty issue descriptions so translation compilation/validation succeeds for non-fixable repair issues. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
arturpragacz
requested changes
Apr 7, 2026
Member
arturpragacz
left a comment
arturpragacz
left a comment
There was a problem hiding this comment.
It is not clear why this would be needed.
Similar to #167463.
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Member
|
Better solution: #167928. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Three sensor repair issues (
units_changed,state_class_removed,mean_type_changed) have emptydescriptionfields instrings.json. All three are created withis_fixable=False, which requires a description translation. Empty strings get stripped during translation compilation, so the keys are missing and the translation validation fails.Added descriptions for each using the placeholders already passed by
recorder.py.Type of change
Additional information
Checklist
ruff format homeassistant tests)To help with the load of incoming pull requests: