Skip to content

Miele - fix core temperature reading#167476

Merged
joostlek merged 5 commits into
home-assistant:devfrom
aturri:feature/miele-fix-core-temperature
Apr 6, 2026
Merged

Miele - fix core temperature reading#167476
joostlek merged 5 commits into
home-assistant:devfrom
aturri:feature/miele-fix-core-temperature

Conversation

@aturri
Copy link
Copy Markdown
Contributor

@aturri aturri commented Apr 5, 2026

Proposed change

Add guards and fix mappings of invalid temperatures, as some appliances use "-3276800" as invalid value (in addition to "-32768"), in order to correctly show the "unknown" state on temperature sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 5, 2026 21:35
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Apr 5, 2026

Hey there @astrandb, mind taking a look at this pull request as it has been labeled with an integration (miele) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of miele can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign miele Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@aturri aturri changed the title Feature/miele fix core temperature Miele - fix core temperature reading Apr 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes invalid temperature value handling in the Miele integration by adding guards to prevent displaying invalid API sentinel values as actual temperature readings. The integration now correctly handles both "-32768" (used by most devices) and "-3276800" (used by some devices) as "no reading" sentinels, ensuring temperature sensors show "unknown" state when the probe is inactive rather than displaying bogus numeric temperatures.

Changes:

  • Enhanced _convert_temperature() function with proper None checks and exception handling for Type/Value errors
  • Extended DISABLED_TEMP_ENTITIES tuple to include scaled sentinel values (-32768.0 and -32766.0) for devices that report int16 minimum values already in degrees
  • Added STEAM_OVEN_MK2 appliance type support to the core temperature sensor definition
  • Improved comments to clarify the logic for optional temperature datapoints
  • Added two comprehensive test cases covering both sentinel value scenarios

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/miele/sensor.py Enhanced temperature conversion with error handling and added STEAM_OVEN_MK2 support for core temperature sensors
homeassistant/components/miele/const.py Extended DISABLED_TEMP_ENTITIES with scaled sentinel values and added clarifying comments
tests/components/miele/test_sensor.py Fixed comment typo and added two new test functions to verify unknown state handling for both sentinel values

@joostlek joostlek added this to the 2026.4.2 milestone Apr 6, 2026
@joostlek joostlek merged commit 0eaa8d3 into home-assistant:dev Apr 6, 2026
33 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 7, 2026
@aturri aturri deleted the feature/miele-fix-core-temperature branch May 1, 2026 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants