Use fixtures for all entity IDs in Evohome tests#167479
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Evohome tests to stop relying on hard-coded entity IDs and instead resolve entity IDs from the entity registry via fixtures, making the suite resilient to entity_id naming changes in the integration.
Changes:
- Replace the hard-coded DHW water heater entity_id in water heater tests with a
dhw_idfixture. - Add an
entity_idhelper fixture (platform + unique_id → entity_id) and refactorctl_id/zone_idto use unique_id-based lookups.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/components/evohome/test_water_heater.py | Switch DHW service calls to use the new dhw_id fixture instead of a constant entity_id. |
| tests/components/evohome/conftest.py | Introduce entity_id/dhw_id fixtures and refactor ctl_id/zone_id to resolve entity_ids via the entity registry and unique_ids. |
joostlek
reviewed
Apr 6, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA.
This prepares Evohome for upcoming changes where it may be possible to have more than one HotWater entity.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: