Skip to content

Refactor to active_containers#167529

Merged
joostlek merged 1 commit into
home-assistant:devfrom
erwindouna:portainer-refactor-active-containers
Apr 7, 2026
Merged

Refactor to active_containers#167529
joostlek merged 1 commit into
home-assistant:devfrom
erwindouna:portainer-refactor-active-containers

Conversation

@erwindouna
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Follow-up of: #167453 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Portainer coordinator’s container stats fetch logic to use clearer “active containers” terminology (running + paused), aligning naming with the actual behavior.

Changes:

  • Renamed the intermediate list from running_containers to active_containers.
  • Updated the accompanying comment to reflect that stats are fetched for running and paused containers.

@joostlek joostlek merged commit 8aa0e9f into home-assistant:dev Apr 7, 2026
36 of 37 checks passed
@erwindouna erwindouna deleted the portainer-refactor-active-containers branch April 7, 2026 16:30
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants