Skip to content

Add kPa as a valid unit of measurement for for pressure in weather entity#2998

Open
RussellAult wants to merge 1 commit intohome-assistant:masterfrom
RussellAult:weather-entity-kpa
Open

Add kPa as a valid unit of measurement for for pressure in weather entity#2998
RussellAult wants to merge 1 commit intohome-assistant:masterfrom
RussellAult:weather-entity-kpa

Conversation

@RussellAult
Copy link
Copy Markdown

@RussellAult RussellAult commented Mar 14, 2026

Proposed change

Add kPa as a valid unit of measurement for pressure in weather

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features for which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Remove stale or deprecated documentation

Checklist

  • I have read and followed the documentation guidelines.
  • I have verified that my changes render correctly in the documentation.

Additional information

Summary by CodeRabbit

  • Documentation
    • Added kilopascal (kPa) pressure unit support to weather documentation, including native pressure properties and forecast data sections.

@RussellAult RussellAult changed the title Add kPa as valid unit for pressure Add kPa as a valid unit of measurement for for pressure in weather entity Mar 14, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 14, 2026

📝 Walkthrough

Walkthrough

Documentation update to weather entity specifications adding kilopascal (kPa) support to pressure-related properties. Changes include updating descriptions and unit lists for native_pressure across main and forecast data sections, with minor formatting adjustments.

Changes

Cohort / File(s) Summary
Weather Documentation
docs/core/entity/weather.md
Added kPa (kilopascal) support to pressure-related properties in native_pressure and native_pressure_unit descriptions, updated corresponding unit lists in both main and forecast data sections, and added trailing newline for file formatting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding kPa as a valid unit for pressure measurement in the weather entity documentation.
Description check ✅ Passed The PR description follows the template structure with all required sections completed, including proposed change, type of change selection, checklist items marked, and relevant link to home-assistant/core#165519.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/core/entity/weather.md`:
- Line 140: Fix the typo in the documentation sentence: change "any ot the
`async_forecast_xxx` methods" to "any of the `async_forecast_xxx` methods" in
the paragraph describing WeatherEntity.async_update_listeners behavior so the
sentence reads correctly and references WeatherEntity.async_update_listeners and
the async_forecast_xxx methods.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: afd09abf-7878-40a2-9aa1-0e0eb8795224

📥 Commits

Reviewing files that changed from the base of the PR and between e7f65cd and e0adf57.

📒 Files selected for processing (1)
  • docs/core/entity/weather.md

It is strongly recommended that fetched weather forecasts are cached by the weather entity to avoid unnecessary API accesses.

When an updated weather forecast is available, the weather forecast cache should be invalidated and the method `WeatherEntity.async_update_listeners` should be awaited to trigger a push of the updated weather forecast to any active subscriber. If there are active listeners, `WeatherEntity.async_update_listeners` will call the corresponding `async_forecast_xxx` methods. If there are no active listeners, `WeatherEntity.async_update_listeners` will not call any ot the `async_forecast_xxx` methods. No newline at end of file
When an updated weather forecast is available, the weather forecast cache should be invalidated and the method `WeatherEntity.async_update_listeners` should be awaited to trigger a push of the updated weather forecast to any active subscriber. If there are active listeners, `WeatherEntity.async_update_listeners` will call the corresponding `async_forecast_xxx` methods. If there are no active listeners, `WeatherEntity.async_update_listeners` will not call any ot the `async_forecast_xxx` methods.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in listener behavior sentence.

Line 140 says “any ot the async_forecast_xxx methods”; this should be “any of …”.

✏️ Proposed doc fix
-When an updated weather forecast is available, the weather forecast cache should be invalidated and the method `WeatherEntity.async_update_listeners` should be awaited to trigger a push of the updated weather forecast to any active subscriber. If there are active listeners, `WeatherEntity.async_update_listeners` will call the corresponding `async_forecast_xxx` methods. If there are no active listeners, `WeatherEntity.async_update_listeners` will not call any ot the `async_forecast_xxx` methods.
+When an updated weather forecast is available, the weather forecast cache should be invalidated and the method `WeatherEntity.async_update_listeners` should be awaited to trigger a push of the updated weather forecast to any active subscriber. If there are active listeners, `WeatherEntity.async_update_listeners` will call the corresponding `async_forecast_xxx` methods. If there are no active listeners, `WeatherEntity.async_update_listeners` will not call any of the `async_forecast_xxx` methods.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
When an updated weather forecast is available, the weather forecast cache should be invalidated and the method `WeatherEntity.async_update_listeners` should be awaited to trigger a push of the updated weather forecast to any active subscriber. If there are active listeners, `WeatherEntity.async_update_listeners` will call the corresponding `async_forecast_xxx` methods. If there are no active listeners, `WeatherEntity.async_update_listeners` will not call any ot the `async_forecast_xxx` methods.
When an updated weather forecast is available, the weather forecast cache should be invalidated and the method `WeatherEntity.async_update_listeners` should be awaited to trigger a push of the updated weather forecast to any active subscriber. If there are active listeners, `WeatherEntity.async_update_listeners` will call the corresponding `async_forecast_xxx` methods. If there are no active listeners, `WeatherEntity.async_update_listeners` will not call any of the `async_forecast_xxx` methods.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/core/entity/weather.md` at line 140, Fix the typo in the documentation
sentence: change "any ot the `async_forecast_xxx` methods" to "any of the
`async_forecast_xxx` methods" in the paragraph describing
WeatherEntity.async_update_listeners behavior so the sentence reads correctly
and references WeatherEntity.async_update_listeners and the async_forecast_xxx
methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants