Clarify integration quality scale expectations for new integrations#3233
Conversation
Emphasize that new integrations must address all bronze level rules, and reference the "Make your pull request as small as possible" section to discourage aiming for higher levels in the initial PR.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis change updates the Core integration contributing guide to require new integrations to reach the bronze quality level and to instruct contributors not to target higher levels immediately. ChangesCore integration contributing guide
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Drive by comment: How I interpreted what was asked for in google health integration was: reach as high as possible given a single platform (e.g. no diagnostics), without adding things that make the PR larger (like reauth). Things like translations, icons, etc are all higher quality things that don't really increase of the initial PR much. |
The existing wording just stated that "It's not required to reach a higher level" because it will "make it harder to review and merge". It can be interpreted as a nudge, but it should be a stronger guideline (since we will likely ask for stuff to be removed from the PR). |
|
Agree on the wording improvement here. Just also saying: in practice we also do ask users to reach a higher levels than bronze if it doesn't make the PR /much/ bigger (e.g. icon translations). Alternatively, just make icon translations bronze. |
Proposed change
Emphasize that new integrations must address all bronze level rules, and
reference the "Make your pull request as small as possible" section to
discourage aiming for higher levels in the initial PR.
Type of change
Checklist
Additional information
Summary by CodeRabbit