Statistics graph card editor: add sub editor#52182
Open
ildar170975 wants to merge 9 commits into
Open
Conversation
ildar170975
changed the title
ildar170975
changed the title
MindFreeze
reviewed
May 24, 2026
MindFreeze
reviewed
May 28, 2026
|
|
||
| private _valueRenderer: PickerValueRenderer = this._makeValueRenderer(); | ||
|
|
||
| private _editItem(ev) { |
Member
There was a problem hiding this comment.
Suggested change
| private _editItem(ev) { | |
| private _editItem(ev: HASSDomEvent<StatisticElementChangedEvent>) { |
Member
There was a problem hiding this comment.
Not sure this is the right type but please put some type on the event
Co-authored-by: Petar Petrov <MindFreeze@users.noreply.github.com>
MindFreeze
reviewed
May 28, 2026
|
|
||
| @query("ha-generic-picker") private _picker?: HaGenericPicker; | ||
|
|
||
| @property({ attribute: "can-edit", type: Boolean }) public canEdit?; |
Member
There was a problem hiding this comment.
Suggested change
| @property({ attribute: "can-edit", type: Boolean }) public canEdit?; | |
| @property({ attribute: "can-edit", type: Boolean }) public canEdit?: boolean; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
A further development for #51824.
SubEditor added for a statistics entry - allows to select a statistics_id, name, color.
A possible improvement - adding a new type for sub-element-editor, otherwise we have that "Entity row editor" label for Statistics Graph card, History Graph card, Map card....
Screenshots
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: