Implemented request-body data insertion through text-editor (#45)

* added feature to add request body through text-editor

* resolved file busy issue

* updated error verb & minor changes

* resolved changes

* minor refactor

* updated readme

* updated readme with suggested changes

* updated print statement for formatted output

Authored by: @devblin 

Co-authored-by: HackMD <no-reply@hackmd.io>

Author: devblin

README.md

@@ -177,3 +177,25 @@ $ cat myrequest.json
 
 $ hopp-cli post -c js http://example.com <myrequest.json
 ```
+
+### Providing a Request Body via text-editor
+
+In addition to providing request body via `-b / --body` flag and stdin,
+you can also use `-e / --editor` flag which opens default text-editor in your system.
+
+**Example:**
+
+```shell
+$ hopp-cli post https://reqres.in/api/users/2 -c js -e
+```
+
+It will preferrably open editor based on `$EDITOR` environment variable.
+
+**For example:**
+If the environment variable is `$EDITOR=code` it will open VSCode for request-body input. Else, it will use default editor value based on the OS.
+
+| OS      | Default Editor |
+| ------- | -------------- |
+| Linux   | `nano`         |
+| macOS   | `nano`         |
+| Windows | `notepad`      |

cli.go

@@ -72,6 +72,10 @@ func main() {
 			Name:  "body, b",
 			Usage: "Body of the Post Request",
 		},
+		cli.BoolFlag{
+			Name:  "editor, e",
+			Usage: "Open editor to insert request body",
+		},
 		cli.StringSliceFlag{
 			Name:  "header, H",
 			Usage: "Header to pass with the request. Can be used multiple times.",
@@ -169,5 +173,5 @@ func main() {
 		l.Println(color.HiRedString("\n%s", err.Error()))
 		os.Exit(1)
 	}
-	fmt.Println(out)
+	fmt.Fprintf(color.Output, out)
 }

methods/basic.go

@@ -3,11 +3,14 @@ package methods
 import (
 	"bytes"
 	"fmt"
-	"io"
+	"io/ioutil"
 	"net/http"
 	"os"
+	"os/exec"
+	"runtime"
 	"strings"
 
+	"github.com/fatih/color"
 	"github.com/urfave/cli"
 )
 
@@ -26,10 +29,61 @@ func BasicRequestWithBody(c *cli.Context, method string) (string, error) {
 		return "", fmt.Errorf("error getting file info for stdin fd: %w", err)
 	}
 	if (stat.Mode() & os.ModeCharDevice) == 0 {
-		body, err = io.ReadAll(os.Stdin)
+		body, err = ioutil.ReadAll(os.Stdin)
 		if err != nil {
 			return "", fmt.Errorf("error reading from stdin: %w", err)
 		}
+	} else if c.Bool("editor") {
+		var path string
+		var editor = os.Getenv("EDITOR")
+
+		if editor == "" {
+			// check OS
+			currentOs := runtime.GOOS
+
+			// based on OS find assign default editor
+			if currentOs == "linux" || currentOs == "darwin" {
+				editor = "nano"
+			} else if currentOs == "windows" {
+				editor = "notepad"
+			}
+		}
+
+		path, err = exec.LookPath(editor)
+		if err != nil {
+			return "", fmt.Errorf("Unable to locate %s: %w", editor, err)
+		}
+
+		// create temp file for writing request body
+		tempFile, err := ioutil.TempFile("", "HOPP-CLI-REQUEST*.txt")
+		if err != nil {
+			return "", fmt.Errorf("Unable to create temp file: %w", err)
+		}
+
+		tempFileName := string(tempFile.Name())
+		defer os.Remove(tempFileName)
+		tempFile.Close()
+
+		// open temp file in selected editor and wait until closed
+		cmd := exec.Command(path, tempFileName)
+		cmd.Stdin = os.Stdin
+		cmd.Stdout = os.Stdout
+
+		if err := cmd.Start(); err != nil {
+			return "", fmt.Errorf("Unable to open editor: %w", err)
+		}
+
+		color.Yellow("Waiting for file to close..\n\n")
+
+		if err := cmd.Wait(); err != nil {
+			return "", fmt.Errorf("Error waiting for file: %w", err)
+		}
+
+		// read temp file contents
+		body, err = ioutil.ReadFile(tempFileName)
+		if err != nil {
+			return "", fmt.Errorf("Error reading file %s: %w", tempFileName, err)
+		}
 	} else {
 		body = []byte(c.String("body"))
 	}