Skip to content

Commit 32394ee

Browse files
committed
style: Use named arguments with Log Handler factory.
1 parent ab6c491 commit 32394ee

1 file changed

Lines changed: 22 additions & 4 deletions

File tree

src/Factory/LogHandlerFactory.php

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,12 @@ public function create(Injector $injector): LogHandler
8686

8787
$options = new Options();
8888
$options->ident = $this->config->getIdent();
89-
$handler = new StreamHandler($this->config->getName(), $append, $options, $formatters);
89+
$handler = new StreamHandler(
90+
streamOrUrl: $this->config->getName(),
91+
mode: $append,
92+
options: $options,
93+
formatters: $formatters
94+
);
9095
break;
9196

9297
case 'syslog':
@@ -99,7 +104,11 @@ public function create(Injector $injector): LogHandler
99104
if (!empty($ident)) {
100105
$options->ident = $ident;
101106
}
102-
$handler = new SyslogHandler($options, $formatters, []);
107+
$handler = new SyslogHandler(
108+
options: $options,
109+
formatters: $formatters,
110+
filters: []
111+
);
103112
break;
104113

105114
case 'null':
@@ -120,7 +129,12 @@ public function createNullHandler(): NullHandler
120129
public function createStreamHandler($streamOrUrl, string $mode = 'a+', ?array $formatters = null, array $filters = []): StreamHandler
121130
{
122131
$options = new Options();
123-
$handler = new StreamHandler($streamOrUrl, $mode, $options, $formatters);
132+
$handler = new StreamHandler(
133+
streamOrUrl: $streamOrUrl,
134+
mode: $mode,
135+
options: $options,
136+
formatters: $formatters
137+
);
124138
foreach ($filters as $filter) {
125139
$handler->addFilter($filter);
126140
}
@@ -129,7 +143,11 @@ public function createStreamHandler($streamOrUrl, string $mode = 'a+', ?array $f
129143

130144
public function createSyslogHandler(array $formatters, array $filters = []): SyslogHandler
131145
{
132-
$handler = new SyslogHandler(new SyslogOptions(), $formatters, $filters);
146+
$handler = new SyslogHandler(
147+
options: new SyslogOptions(),
148+
formatters: $formatters,
149+
filters: $filters
150+
);
133151
return $handler;
134152
}
135153
}

0 commit comments

Comments
 (0)