Skip to content

Refactor VarRenderer class to use candidates for class loading #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TDannhauer wants to merge 1 commit into from
Closed

Refactor VarRenderer class to use candidates for class loading #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions lib/Horde/Core/Ui/VarRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

use Horde\Util\HordeString;

/**
* Copyright 2003-2026 Horde LLC (http://www.horde.org/)
*
Expand Down Expand Up @@ -62,24 +64,30 @@ public static function factory($driver, $params = [])
$app = '';
}

$driver = Horde_String::ucfirst(basename($driver));
$class = (empty($app) ? 'Horde_Core' : $app) . '_Ui_VarRenderer_' . $driver;

$ok = class_exists($class);
$driverName = HordeString::ucfirst(basename((string) $driver));
$candidates = [];

// TODO: Eliminate after renaming Horde_Ui_VarRenderer_* classes in other apps to {app}_Ui_VarRenderer_*
if (!$ok && !empty($app)) {
// fallback to legacy method (manual load)
$class = __CLASS__ . '_' . $driver;
include_once $GLOBALS['registry']->get('fileroot', $app) . '/lib/Ui/VarRenderer/' . $driver . '.php';
$ok = class_exists($class);
if ($app === '' || $app === null) {
$candidates[] = 'Horde_Core_Ui_VarRenderer_' . $driverName;
} else {
$appPrefix = (string) $app;
$candidates[] = HordeString::ucfirst($appPrefix) . '_Ui_VarRenderer_' . $driverName;
if ($appPrefix !== HordeString::ucfirst($appPrefix)) {
$candidates[] = $appPrefix . '_Ui_VarRenderer_' . $driverName;
}
$candidates[] = 'Horde_Core_Ui_VarRenderer_' . $driverName;
}

if (!$ok) {
throw new LogicException('Class definition of ' . $class . ' not found.');
foreach ($candidates as $class) {
if (class_exists($class)) {
return new $class($params);
}
}

return new $class($params);
throw new LogicException(
'Class definition not found for VarRenderer driver. Tried: '
. implode(', ', $candidates)
);
}

/**
Expand Down
Loading