Skip to content

Commit 9f850f3

Browse files
committed
fix(test.php): Don't use red-on-grey for code values which are not meant to be bad.
1 parent 0c8eb9d commit 9f850f3

3 files changed

Lines changed: 15 additions & 4 deletions

File tree

lib/Test.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,6 +1092,7 @@ public function _subSystemCheck()
10921092
$details .= ", Active: <code>{$actualHandler}</code>";
10931093

10941094
// Check if this is Horde_SessionHandler wrapper and introspect the storage backend
1095+
$storageClass = null;
10951096
if ($actualHandler === 'Horde_SessionHandler') {
10961097
try {
10971098
$reflection = new ReflectionClass($session->sessionHandler);
@@ -1115,10 +1116,12 @@ public function _subSystemCheck()
11151116
}
11161117

11171118
// Check if configuration matches reality
1119+
// When checking wrapped handlers, use the storage class instead of the wrapper
1120+
$handlerToCheck = $storageClass ?? $actualHandler;
11181121
$matches = true;
1119-
if ($configuredType === 'Builtin' && !preg_match('/Builtin/i', $actualHandler)) {
1122+
if ($configuredType === 'Builtin' && !preg_match('/Builtin/i', $handlerToCheck)) {
11201123
$matches = false;
1121-
} elseif ($configuredType === 'External' && !preg_match('/External/i', $actualHandler)) {
1124+
} elseif ($configuredType === 'External' && !preg_match('/External/i', $handlerToCheck)) {
11221125
$matches = false;
11231126
}
11241127

templates/test/test.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,11 @@ h1 {
88
font-family: Verdana,Geneva,Arial,Helvetica,sans-serif;
99
font-size: 110%;
1010
}
11+
12+
code {
13+
background-color: #e8e8e8;
14+
color: #1a1a1a;
15+
padding: 2px 6px;
16+
border-radius: 3px;
17+
font-family: 'Courier New', Courier, monospace;
18+
}

themes/default/tests.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@ a:hover {
5252
}
5353

5454
code {
55-
background-color: #ecf0f1;
55+
background-color: #e8e8e8;
5656
padding: 2px 6px;
5757
border-radius: 3px;
5858
font-family: "Courier New", Courier, monospace;
5959
font-size: 13px;
60-
color: #e74c3c;
60+
color: #1a1a1a;
6161
}
6262

6363
strong {

0 commit comments

Comments
 (0)