Fix loading countries in non-pear scenarios.#5
Closed
ralflang wants to merge 1 commit into
Closed
Conversation
See https://github.com/maintaina-com/Nls/tree/pr-autoload-issue This change is backward compatible and should work with the unchanged Nls package no worse than before, with the updated nls package it fixes composer.
Member
Author
|
See PR horde/Nls#1 |
Member
Author
|
Nls::getCountryISO() called without parameter might also return the bare code => Name hash, so we could leverage that. I haven't originally looked into this as I have the same problem in Horde_Form with multiple other data types. |
Member
Author
|
Superseded by the framework-wide PSR-4 Nls migration. Country loading now uses the modern
The underlying problem (country loading failing in non-PEAR/Composer scenarios) is resolved by the PSR-4 package which uses proper autoloading throughout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Try autoloader when loading countries before reverting to file includes.
See https://github.com/maintaina-com/Nls/tree/pr-autoload-issue
This change is backward compatible and should work with the unchanged Nls package no worse than before, with the updated nls package it fixes composer.