Add PHP 8 compatibility, end PHP 7.2 support (#67)

Author: janlam7

.github/workflows/main.yaml

@@ -12,7 +12,7 @@ jobs:
 
     strategy:
       matrix:
-        php-versions: ['7.3', '7.4']
+        php-versions: ['7.3', '7.4', '8.0']
     name: PHP ${{ matrix.php-versions }}
     steps:
       -   uses: actions/checkout@v2

composer.json

@@ -4,7 +4,7 @@
     "description": "PHP_CodeSniffer tokenises PHP, JavaScript and CSS files and detects violations of a defined set of coding standards. Hostnet version",
     "license":     "MIT",
     "require": {
-        "php":                              ">=7.2",
+        "php":                              "^7.3|^8.0",
         "composer-plugin-api":              "^2.0.0",
         "hostnet/path-composer-plugin-lib": "^1.0.4",
         "slevomat/coding-standard":         "^7.0.9",
@@ -13,7 +13,7 @@
     },
     "require-dev": {
         "composer/composer": "^2.0.2",
-        "phpunit/phpunit":   "^6.5.4"
+        "phpunit/phpunit":   "^9.5.6"
     },
     "autoload": {
         "psr-0": {

phpcs.xml.dist

@@ -3,4 +3,6 @@
   <rule ref="Hostnet"/>
   <!-- Copied from mediawiki-codesniffer -->
   <exclude-pattern>src/Hostnet/Sniffs/Classes/MultipleEmptyLinesSniff.php</exclude-pattern>
+  <!-- Copied from squizlabs/php_codesniffer -->
+  <exclude-pattern>test/Hostnet/Tests/CopiedAbstractSniffUnitTest.php</exclude-pattern>
 </ruleset>

src/Hostnet/Sniffs/Commenting/AtCoversCounterPartSniff.php

@@ -99,6 +99,11 @@ private function extractCoverageNamespaces(File $phpcs_file, int $close_tag_posi
 
     private function getNamespaceFromFile(string $path_to_file): string
     {
+        // PHP 8.0 forward compatibility @see https://www.php.net/manual/en/migration80.incompatible.php
+        if (!defined('T_NAME_QUALIFIED')) {
+            define('T_NAME_QUALIFIED', T_NS_SEPARATOR);
+        }
+
         $namespace = '';
         $class     = '';
 
@@ -118,7 +123,7 @@ private function getNamespaceFromFile(string $path_to_file): string
 
             if ($getting_namespace) {
                 // If the token is a string or the namespace separator.
-                if (\is_array($token) && \in_array($token[0], [T_STRING, T_NS_SEPARATOR], true)) {
+                if (\is_array($token) && \in_array($token[0], [T_STRING, T_NS_SEPARATOR, T_NAME_QUALIFIED], true)) {
                     // Append the token's value to the name of the namespace.
                     $namespace .= $token[1];
                 } elseif ($token === ';') {

test/Hostnet/Tests/AbstractSniffUnitTest.php

@@ -8,21 +8,20 @@
 
 use PHP_CodeSniffer\Config;
 use PHP_CodeSniffer\Ruleset;
-use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest as AbstractSniffUnitTestCodeSniffer;
 use PHP_CodeSniffer\Tests\Standards\AllSniffs;
 
 /**
  * This class acts as a bridge between our unit-tests and the PHPCodeSniffer Unit-Testing framework.
  * It setup the environment; loading our 'code standard' etc.
  */
-abstract class AbstractSniffUnitTest extends AbstractSniffUnitTestCodeSniffer
+abstract class AbstractSniffUnitTest extends CopiedAbstractSniffUnitTest
 {
     /**
      * Prepare our code standard setup, PHP Code Sniffer performs this in AllTests
      *
      * @see AbstractSniffUnitTest::setUp()
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         new AllSniffs();
 
@@ -35,7 +34,7 @@ protected function setUp()
         parent::setUp();
     }
 
-    public function doesNotPerformAssertions()
+    public function doesNotPerformAssertions(): bool
     {
         return true;
     }