fix: use pull_request.user.login instead of github.actor for Dependabot check#13
Merged
Merged
Conversation
…ot check github.actor is set to the workflow runner identity (github-actions[bot]) in org-required workflows, not the PR author. Switch to github.event.pull_request.user.login which always reflects who opened the PR.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.actor == 'dependabot[bot]'checks withgithub.event.pull_request.user.login == 'dependabot[bot]'Root cause
The
claude-pr-review.ymlworkflow is enforced via an org ruleset as a required workflow. When required workflows run,github.actoris set to the workflow runner identity (github-actions[bot]), not the user who triggered the PR event. This means the Dependabot checkgithub.actor == 'dependabot[bot]'always evaluates tofalse, so:HOTDATA_AUTOMATION_PRIVATE_KEYis inaccessible whenSecret source: DependabotFix
Switch to
github.event.pull_request.user.login, which always reflects the PR author regardless of the workflow runner context.Test plan
hotdata-dev/hotdata-langgraphPR fix: allow hotdata-automation bot to trigger PR reviews #8 — "Auto-approve Dependabot bump" step should run and succeed