feat(search): make --catalog required and use default_catalog for vector queries

- Add `default_catalog` field to `Database` struct (returned by API)
- Make `--catalog` required on `search` and `indexes create` commands
  instead of falling back to the active database config
- Use `db.default_catalog` as the vector table prefix so the query
  resolves against the correct catalog alias, not the resolved name

Author: eddietejeda

src/command.rs

@@ -173,9 +173,9 @@ pub enum Commands {
         #[arg(long, value_parser = ["vector", "bm25"])]
         r#type: Option<String>,
 
-        /// Catalog (database name) to search in. Defaults to the current database.
+        /// Catalog (database id or name) to search in.
         #[arg(long)]
-        catalog: Option<String>,
+        catalog: String,
 
         /// Schema to search in (default: public)
         #[arg(long)]
@@ -337,8 +337,8 @@ pub enum IndexesCommands {
 
     /// Create an index on a table
     Create {
-        /// Catalog (database name) for the table to index. Defaults to the current database.
-        #[arg(long, conflicts_with = "dataset_id")]
+        /// Catalog (database id or name) for the table to index.
+        #[arg(long, conflicts_with = "dataset_id", required_unless_present = "dataset_id")]
         catalog: Option<String>,
 
         /// Schema for the table to index (default: public)

src/databases.rs

@@ -25,6 +25,7 @@ pub struct Database {
     #[serde(default)]
     pub name: Option<String>,
     pub default_connection_id: String,
+    pub default_catalog: String,
     #[serde(default)]
     attachments: Vec<DatabaseAttachment>,
 }
@@ -891,7 +892,7 @@ mod tests {
 
     fn full_detail(id: &str, name: &str, conn_id: &str) -> String {
         format!(
-            r#"{{"id":"{id}","name":"{name}","default_connection_id":"{conn_id}","attachments":[]}}"#
+            r#"{{"id":"{id}","name":"{name}","default_connection_id":"{conn_id}","default_catalog":"default","attachments":[]}}"#
         )
     }
 

src/main.rs

@@ -709,19 +709,7 @@ fn main() {
                                         std::process::exit(1);
                                     });
                                     let sch = schema.unwrap_or_else(|| "public".to_string());
-                                    let cat = catalog
-                                        .or_else(|| {
-                                            crate::config::load_current_database(
-                                                "default",
-                                                &workspace_id,
-                                            )
-                                        })
-                                        .unwrap_or_else(|| {
-                                            eprintln!(
-                                                "error: --catalog is required (or set a current database with 'hotdata databases set')"
-                                            );
-                                            std::process::exit(1);
-                                        });
+                                    let cat = catalog.unwrap();
                                     let db = databases::resolve_database(&api, &cat);
                                     let conn_id = db.default_connection_id;
                                     let auto =
@@ -851,17 +839,7 @@ fn main() {
                 let workspace_id = resolve_workspace(workspace_id);
 
                 let api = api::ApiClient::new(Some(&workspace_id));
-                let cat = catalog
-                    .or_else(|| {
-                        crate::config::load_current_database("default", &workspace_id)
-                    })
-                    .unwrap_or_else(|| {
-                        eprintln!(
-                            "error: --catalog is required (or set a current database with 'hotdata databases set')"
-                        );
-                        std::process::exit(1);
-                    });
-                let db = databases::resolve_database(&api, &cat);
+                let db = databases::resolve_database(&api, &catalog);
                 let resolved_schema = schema.unwrap_or_else(|| "public".to_string());
                 let db_id = db.id.clone();
                 let conn_id = db.default_connection_id;
@@ -871,7 +849,7 @@ fn main() {
                 // arguments. Use the connection ID as the catalog prefix so it resolves directly.
                 let bm25_table = format!("{}.{}.{}", conn_id, resolved_schema, table);
                 // vector queries run as standard SQL with X-Database-Id, so the catalog alias works.
-                let vector_table = format!("{}.{}.{}", cat, resolved_schema, table);
+                let vector_table = format!("{}.{}.{}", db.default_catalog, resolved_schema, table);
 
                 // Infer --type and --column from the table's indexes when either is omitted.
                 let (resolved_type, resolved_column) =