Address PR review: serde default, URL encoding, save warning, arg order

- `Database.attachments` gets `#[serde(default)]` so the server can omit
  the field without causing a hard parse failure
- `try_resolve_database` percent-encodes the path segment via `urlencoding`
  so descriptions containing spaces don't crash the URL parse before the
  list fallback runs
- `create` now warns (yellow) instead of silently discarding a config save
  failure, so the user knows the implicit "set as current" didn't take
- `set(id_or_description, workspace_id)` → `set(workspace_id, id_or_description)`
  to match the argument order of every other public fn in databases.rs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: eddietejeda

Cargo.lock

@@ -40,6 +40,7 @@ sysinfo = { version = "0.38.4", default-features = false, features = ["system"]
 self_update = { version = "0.42", default-features = false, features = ["rustls"] }
 lzma-rs = "0.3"
 tempfile = "3"
+urlencoding = "2.1.3"
 
 [dev-dependencies]
 mockito = "1"

Cargo.toml

@@ -23,6 +23,7 @@ pub struct Database {
     pub id: String,
     pub description: Option<String>,
     pub default_connection_id: String,
+    #[serde(default)]
     attachments: Vec<DatabaseAttachment>,
 }
 
@@ -82,7 +83,10 @@ fn fetch_database(api: &ApiClient, id: &str) -> Database {
 
 pub fn try_resolve_database(api: &ApiClient, id_or_description: &str) -> Result<Database, String> {
     // Try a direct id lookup first — avoids the list round-trip for the common case.
-    if let Some(db) = api.get_none_if_not_found(&format!("/databases/{id_or_description}")) {
+    // Percent-encode the segment so descriptions containing spaces or other URL-unsafe
+    // characters don't cause a URL parse error before the list fallback can run.
+    let encoded = urlencoding::encode(id_or_description);
+    if let Some(db) = api.get_none_if_not_found(&format!("/databases/{encoded}")) {
         return Ok(db);
     }
 
@@ -436,7 +440,10 @@ pub fn create(
         }
     };
 
-    let _ = crate::config::save_current_database("default", workspace_id, &result.id);
+    if let Err(e) = crate::config::save_current_database("default", workspace_id, &result.id) {
+        use crossterm::style::Stylize;
+        eprintln!("{}", format!("warning: database created but could not set as current: {e}").yellow());
+    }
 
     match format {
         "json" => println!("{}", serde_json::to_string_pretty(&result).unwrap()),
@@ -452,7 +459,7 @@ pub fn create(
     }
 }
 
-pub fn set(id_or_description: &str, workspace_id: &str) {
+pub fn set(workspace_id: &str, id_or_description: &str) {
     use crossterm::style::Stylize;
     let api = ApiClient::new(Some(workspace_id));
     let db = resolve_database(&api, id_or_description);

src/databases.rs

@@ -416,7 +416,7 @@ fn main() {
                             &output,
                         ),
                         Some(DatabasesCommands::Set { id_or_description }) => {
-                            databases::set(&id_or_description, &workspace_id)
+                            databases::set(&workspace_id, &id_or_description)
                         }
                         Some(DatabasesCommands::Delete { name_or_id }) => {
                             databases::delete(&workspace_id, &name_or_id)