Skip to content

Commit a2e4ad3

Browse files
committed
docs: describe current behavior, not change history, in comments
1 parent b12c792 commit a2e4ad3

2 files changed

Lines changed: 9 additions & 15 deletions

File tree

Cargo.toml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,10 @@ path = "src/main.rs"
1313

1414
[dependencies]
1515
# Hotdata Rust SDK. The CLI's sync wrapper (src/sdk.rs) drives this async SDK
16-
# behind a shared multi-thread tokio runtime. Pinned to the rev that adds
17-
# `content_length` to the streaming `upload_stream` (sized body, not chunked, so
18-
# the server can fast-fail an oversized upload) — merged via hotdata-dev/sdk-rust#35
19-
# (which subsumes the earlier #32 CLI-consumption surface: attribution
20-
# client_id, async submit_query, streaming upload_stream).
16+
# behind a shared multi-thread tokio runtime. The `arrow` feature backs result
17+
# decode; the pinned rev is the first to carry `content_length` on the streaming
18+
# `upload_stream` (sized body, not chunked, so the server can fast-fail an
19+
# oversized upload — see src/sdk.rs::Api::upload_stream).
2120
hotdata = { git = "https://github.com/hotdata-dev/sdk-rust", rev = "1687ba2ffb8f816540d00d7c1fdfe165a8fbd150", features = ["arrow"] }
2221
# Shared multi-thread runtime for the sync wrapper; block_on is called
2322
# concurrently from rayon worker threads (see src/indexes.rs). `sync` backs the

src/raw_http.rs

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,13 @@
1010
//! `sandbox_session.rs`);
1111
//! * `skill.rs`'s arbitrary-URL markdown fetch.
1212
//!
13-
//! (The streaming `/files` upload moved onto the SDK seam's
14-
//! [`Api::upload_stream`](crate::sdk::Api::upload_stream), which owns its own
15-
//! no-timeout client.)
16-
//!
1713
//! This module owns the timeout-bounded blocking client builder and a thin
18-
//! bearer/header request builder. It does NOT carry the old `ApiClient`'s
19-
//! 401-retry loop: token freshness is now the `CliTokenProvider`'s job
20-
//! (proactive refresh at the 30s leeway).
14+
//! bearer/header request builder. Token freshness is the `CliTokenProvider`'s
15+
//! job (proactive refresh at the 30s leeway), so these helpers carry no
16+
//! 401-retry loop.
2117
22-
// Consumers (jwt.rs token mints, session mints, the streaming upload,
23-
// skill.rs) are migrated to this helper incrementally; the allow keeps the
24-
// build warning-free until those call sites land.
18+
// Not every helper here is wired to a call site yet; the allow keeps the build
19+
// warning-free.
2520
#![allow(dead_code)]
2621

2722
use std::time::Duration;

0 commit comments

Comments
 (0)