Commit e2e151d
fix: address code review feedback from post-release audit
- query.rs: remove dead AsyncResponse.status field (was the source of
the dead_code compiler warning; field was printed pre-polling but is
unused now that the loop reads QueryRunResponse.status)
- query.rs: reorder polling loop — poll first, then check deadline and
sleep; eliminates the mandatory 500ms delay before the first check and
ensures timeout is detected without an extra sleep cycle
- skill.rs: add 120s timeout to download_and_extract_from_url HTTP
client, matching the timeout used in perform_update; prevents an
indefinite hang during hotdata update if the skills download stalls
- main.rs: replace chained .unwrap() with .expect() in the databases
tables help path for clearer panic messages if subcommand names change
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 84095c0 commit e2e151d
3 files changed
Lines changed: 19 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
484 | 484 | | |
485 | 485 | | |
486 | 486 | | |
487 | | - | |
| 487 | + | |
488 | 488 | | |
489 | | - | |
| 489 | + | |
490 | 490 | | |
491 | | - | |
| 491 | + | |
492 | 492 | | |
493 | 493 | | |
494 | 494 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
184 | 183 | | |
185 | 184 | | |
186 | 185 | | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | 186 | | |
199 | 187 | | |
200 | 188 | | |
| |||
218 | 206 | | |
219 | 207 | | |
220 | 208 | | |
221 | | - | |
| 209 | + | |
222 | 210 | | |
223 | 211 | | |
224 | 212 | | |
| |||
230 | 218 | | |
231 | 219 | | |
232 | 220 | | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
233 | 232 | | |
234 | 233 | | |
235 | 234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | | - | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
209 | 212 | | |
210 | 213 | | |
211 | 214 | | |
| |||
0 commit comments