Skip to content

feat(query): remove dead --connection flag#138

Merged
zfarrell merged 1 commit into
mainfrom
chore/remove-dead-query-connection-flag
Jun 5, 2026
Merged

feat(query): remove dead --connection flag#138
zfarrell merged 1 commit into
mainfrom
chore/remove-dead-query-connection-flag

Conversation

@zfarrell

@zfarrell zfarrell commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Removes the query --connection flag, a confirmed no-op since the SDK refactor stopped sending the ignored connection_id field. Docs updated to point to -d/--database.

Closes #132

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean dead-code removal. The --connection flag is removed consistently from the command enum, the main.rs destructuring, both query::execute call sites, the function signature, and all docs. No remaining references to the flag.

@sentry

sentry Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main.rs 0.00% 3 Missing ⚠️
src/query.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@zfarrell zfarrell merged commit b5aac4a into main Jun 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove/deprecate the dead 'query --connection' flag

1 participant