feat(query): decode results via SDK get_result_arrow (arrow v55)#140
Conversation
There was a problem hiding this comment.
Clean arrow v54→v55 bump routing the result fetch through the SDK's get_result_arrow. Decode output stays equivalent (same schema-derived columns + per-row arrow_cell conversion), from_arrow preserves status-bearing variants so the 4xx re-auth hint still fires, and the new tests meaningfully cover decode, 404, and generic-HTTP status mapping. LGTM.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Clean, well-tested refactor. Verified removed symbols leave no dangling references, from_arrow preserves status-bearing variants for the re-auth hint, the Arrow fetch only runs after succeeded so there's no not-ready path, and output parity is maintained. Tests cover the IPC round-trip plus 404/403 status mapping.
Closes #130. Bumps the CLI's
arrowcrate v54→v55 to match the SDK and switches the Arrow result fetch from the rawget_bytesIPC path to the SDK'sClient::get_result_arrow, so transport and decode share one arrow version. Output stays byte-identical (same schema-derived columns andarrow_cellrow conversion).