Skip to content

feat(query): decode results via SDK get_result_arrow (arrow v55)#140

Merged
zfarrell merged 3 commits into
mainfrom
feat/arrow-v55-get-result-arrow
Jun 5, 2026
Merged

feat(query): decode results via SDK get_result_arrow (arrow v55)#140
zfarrell merged 3 commits into
mainfrom
feat/arrow-v55-get-result-arrow

Conversation

@zfarrell

@zfarrell zfarrell commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Closes #130. Bumps the CLI's arrow crate v54→v55 to match the SDK and switches the Arrow result fetch from the raw get_bytes IPC path to the SDK's Client::get_result_arrow, so transport and decode share one arrow version. Output stays byte-identical (same schema-derived columns and arrow_cell row conversion).

claude[bot]
claude Bot previously approved these changes Jun 5, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean arrow v54→v55 bump routing the result fetch through the SDK's get_result_arrow. Decode output stays equivalent (same schema-derived columns + per-row arrow_cell conversion), from_arrow preserves status-bearing variants so the 4xx re-auth hint still fires, and the new tests meaningfully cover decode, 404, and generic-HTTP status mapping. LGTM.

@sentry

sentry Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.22078% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/query.rs 0.00% 9 Missing ⚠️
src/sdk.rs 89.70% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-tested refactor. Verified removed symbols leave no dangling references, from_arrow preserves status-bearing variants for the re-auth hint, the Arrow fetch only runs after succeeded so there's no not-ready path, and output parity is maintained. Tests cover the IPC round-trip plus 404/403 status mapping.

@zfarrell zfarrell merged commit 3d7b989 into main Jun 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch arrow result decoding to the SDK's get_result_arrow (v54→v55)

1 participant