Skip to content

chore: Remove sandbox cli commands#144

Merged
pthurlow merged 9 commits into
mainfrom
chore/remove-sandbox-cli
Jun 5, 2026
Merged

chore: Remove sandbox cli commands#144
pthurlow merged 9 commits into
mainfrom
chore/remove-sandbox-cli

Conversation

@pthurlow

@pthurlow pthurlow commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@sentry

sentry Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/auth.rs 47.61% 11 Missing ⚠️
src/context.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

claude[bot]
claude Bot previously approved these changes Jun 5, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal of the sandbox CLI surface — source, tests, deps, and docs are all consistent, and the workspace-env lock tests were correctly reworked onto datasets list.

super nit (not blocking): src/sdk.rs:497 still references X-Session-Id in the upload_stream doc comment, but that header was removed with the sandbox session scope. It now only carries X-Workspace-Id.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal of the sandbox CLI subsystem. Verified no dangling references remain, the ProfileConfig.sandbox field drop is backward-compatible (no deny_unknown_fields), the auth-precedence collapse is consistent across auth.rs/sdk.rs/jwt.rs, and the workspace-env-lock tests were correctly migrated to tests/workspace_env.rs.

@pthurlow pthurlow merged commit aa20ab1 into main Jun 5, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant