-
Notifications
You must be signed in to change notification settings - Fork 0
chore(ci): add Dependabot to track published hotdata SDK #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+15
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Keeps the CLI current with published Hotdata SDK releases. Scoped to the | ||
| # `hotdata` crate so unrelated transitive deps don't churn; when a new version | ||
| # is published to crates.io, Dependabot opens a `chore(deps)` PR (gated by CI). | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: cargo | ||
| directory: "/" | ||
| schedule: | ||
| interval: daily | ||
| allow: | ||
| - dependency-name: "hotdata" | ||
| commit-message: | ||
| prefix: "chore(deps)" | ||
| labels: | ||
| - dependencies | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config won't track crates.io releases of the SDK as intended. In
Cargo.toml:20,hotdatais a git dependency pinned to arev:Dependabot resolves updates from a dependency's declared source, not crates.io. Since the manifest sources
hotdatafrom git, a crates.io publish is invisible to this config — the premise in the PR description and the header comment ("when a new version is published to crates.io") doesn't hold here.For a git dependency, Dependabot's cargo updater only advances deps that track a branch (to the latest commit) or a tag; it does not reliably bump a dependency pinned to an explicit
rev. So as written this is likely to open no PRs at all. And if it did advance the rev, it would bump to arbitrary default-branch commits — which directly conflicts with the deliberately pinned rev documented inCargo.toml(the comment there explains this exact rev is the first to carrycontent_lengthonupload_stream).To achieve the stated goal you'd need to either (a) switch the SDK to a crates.io dependency (
hotdata = "x.y"), then this config works as described, or (b) track the git source explicitly (e.g. point the dep at abranch/tagand accept that Dependabot follows git, not crates.io). Please reconcile the config with how the dependency is actually sourced.