-
Notifications
You must be signed in to change notification settings - Fork 0
docs(skills): document fork re-attach behavior and add fork-before-risky-changes workflow #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5f78374
docs(skills): document fork connection re-attach, active-db side effe…
eddietejeda 0392d57
docs(skills): reference source database by id in fork workflow; docum…
eddietejeda 93db544
docs(skills): database selection is always by id — names and catalogs…
eddietejeda c63bb38
docs(skills): fork workflow — capture the fork id too; delete by fork id
eddietejeda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
databases setresolves by database id, not a catalog alias. TheSetsubcommand's arg is documented as "Database id" (src/commands/databases.rs:123-126), andset→get_databaseperforms a directGET /v1/databases/{id}with no catalog/name resolution (src/commands/databases.rs:1467-1493,410-412). Every other doc example useshotdata databases set <id>— this new workflow is the only place that passes a catalog alias (set sales).Two concrete problems:
Opening line —
hotdata databases set salesuses the catalog aliassales, butsetexpects an id, so this likely errors withno database with id 'sales'.Cleanup line 145 — "keep the fork (
databases setback to the source)" is unreachable as written. After the fork, the source and the fork both answer to catalogsales(the fork inherits the source's catalog —src/commands/databases.rs:570-572), so there is no unambiguous alias for the source. Even client-side catalog resolution errors here (resolve_database→ "multiple databases have catalog 'sales' — use the database id instead",src/commands/databases.rs:457-466). The agent has no source id to fall back to because the whole workflow deliberately used the alias.Suggested fix: capture the source id up front (e.g. from
databases <id_or_name>/databases list) and use ids forset, or make the workflow reference the source by id explicitly in the cleanup step. This keeps the guidance executable for an agent following it verbatim.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0392d57 — confirmed against the source that
setis id-only (set->get_database, direct GET with no catalog/name fallback) whilefork/delete/inspect resolve viaresolve_database. The workflow now captures the source id up front (databases list), uses it fordatabases set, and calls out explicitly that after the fork the shared catalog alias makes the id the only unambiguous handle on the source. Also corrected the pre-existingset <id_or_name>usage in SKILL.md toset <id>since it's the same defect class.