Skip to content

feat(databases): migrate to dedicated databases API #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddietejeda merged 5 commits into from
May 22, 2026
Merged

feat(databases): migrate to dedicated databases API #94

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
080d894
feat(databases): migrate to dedicated databases API
eddietejeda May 22, 2026
d2bf005
feat(databases): add current database context with set and auto-set o…
eddietejeda May 22, 2026
df44c0a
feat(query): send X-Database-Id header when current database is set
eddietejeda May 22, 2026
fc1e090
Scope current database per workspace; clear on delete
eddietejeda May 22, 2026
93bdd18
Address PR review: serde default, URL encoding, save warning, arg order
eddietejeda May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ pub enum Commands {

/// Managed databases you create and populate with tables (parquet uploads)
Databases {
/// Database name or connection ID (omit to use a subcommand)
/// Database id or description (omit to use a subcommand)
Comment thread
eddietejeda marked this conversation as resolved.
name_or_id: Option<String>,

/// Workspace ID (defaults to first workspace from login)
Expand Down Expand Up @@ -557,15 +557,15 @@ pub enum DatabasesCommands {

/// Create a new managed database
Create {
/// Database name (used as the connection name in SQL: `name.schema.table`)
/// Optional display label (not unique, not an identifier — databases are addressed by id)
#[arg(long)]
name: String,
description: Option<String>,

/// Schema for tables declared at create time (default: public)
#[arg(long, default_value = "public")]
schema: String,

/// Table to declare up front (repeatable). Required before load on current API.
/// Table to declare up front (repeatable)
#[arg(long = "table")]
tables: Vec<String>,

Expand Down
Loading
Loading