Commit 1379aa0
committed
fix: tighten decimal regex and fall through on unknown duration unit
Two nits from PR review:
- decimal regex 'decimal128?' made only the trailing 8 optional, so it
matched the non-existent 'decimal12' form. Changed to
'decimal(?:128|256)?' to accept decimal, decimal128, or decimal256.
- _ARROW_UNIT_TO_IBIS.get(..., 's') silently mapped any unrecognised
duration unit (e.g. duration[foo]) to Interval(s). Now returns None
so the caller falls through to the Postgres parser / String fallback.1 parent bddb9f2 commit 1379aa0
2 files changed
Lines changed: 20 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
116 | 123 | | |
117 | 124 | | |
118 | 125 | | |
119 | 126 | | |
120 | 127 | | |
| 128 | + | |
121 | 129 | | |
122 | 130 | | |
| 131 | + | |
123 | 132 | | |
124 | 133 | | |
125 | 134 | | |
| |||
150 | 159 | | |
151 | 160 | | |
152 | 161 | | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
0 commit comments