deps: upgrade hotdata SDK to 0.2.4#19
Merged
Merged
Conversation
Bumps the hotdata dependency to >=0.2.4 and updates callers for the breaking rename of `description` → `name` on `CreateDatabaseRequest`, `DatabaseSummary`, and `DatabaseDetailResponse`. - `http.py`: pass `name=` instead of `description=` to `CreateDatabaseRequest` - `backend.py`: scan list by `db["name"]` instead of `db["description"]` - tests: update mock request assertions and response fixtures accordingly
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| ) | ||
| ] | ||
| req = CreateDatabaseRequest(description=description, schemas=schemas) | ||
| req = CreateDatabaseRequest(name=description, schemas=schemas) |
There was a problem hiding this comment.
nit: (not blocking) the surrounding parameter is still named description (line 198) but now maps to the SDK's name field. Consider renaming the parameter to name for consistency with the SDK rename — the only internal caller (backend.py:597) would update from description=name to name=name.
| raise _ibis_err_from_hotdata(exc) from exc | ||
| for db in data.get("databases", []): | ||
| if db.get("description") == name_or_id: | ||
| if db.get("name") == name_or_id: |
There was a problem hiding this comment.
nit: (not blocking) several nearby comments/docstrings still describe the lookup as "by id or description" or "Fall back to description scan" (lines 340, 350, 364, 588). Worth updating the prose to match the renamed field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hotdatadependency to>=0.2.4and updatesuv.lockdescription→nameonCreateDatabaseRequest,DatabaseSummary, andDatabaseDetailResponseintroduced in SDK 0.2.4Changes
pyproject.toml/uv.lock:hotdata>=0.2.3→>=0.2.4src/ibis_hotdata/http.py:CreateDatabaseRequest(description=…)→name=…src/ibis_hotdata/backend.py: database list-scan lookup usesdb["name"]instead ofdb["description"]tests/: mock request assertions and response fixtures updated to match the renamed fieldTest plan
uv run pytest tests/ -v)