ci: add Dependabot and auto-merge for hotdata SDK updates#7
Merged
Conversation
There was a problem hiding this comment.
Review
Blocking Issues
.github/dependabot.yml: PR claims to add auto-merge for hotdata SDK updates, but no auto-merge workflow is included in the diff. Only the Dependabot config is added..github/dependabot.yml: Config has noallow:filter, so it will open PRs for every pip dependency (hotdata-runtime, hotdata, llama-index-core, pytest), not justhotdataas the title/description states.
Action Required
Either:
- Add the missing auto-merge workflow (gated on
dependabot[bot]actor +dependabot/fetch-metadatato verify the updated package is in the hotdata SDK), and add anallow:filter to scope Dependabot to the hotdata packages; or - Update the PR title and description to accurately reflect that this change only enables daily Dependabot for all pip dependencies, with no auto-merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds daily Dependabot checks scoped to
hotdataandhotdata-runtimepackages, and an auto-merge workflow that squash-merges those PRs once all checks pass.dependabot.yml: watches the correct package ecosystem (uvwhereuv sync --lockedis used in CI,pipotherwise), scoped viaallow:to hotdata packages onlydependabot-automerge.yml: enables squash auto-merge on any PR opened bydependabot[bot]