Commit abf9ec6
authored
refactor: simplify redundant expressions in display and workspace_selector (#11)
* feat: add database= parameter to sql engine and editor for managed database scoping
Pass database= to client.execute_sql() so queries are scoped to a
managed database via the X-Database-Id header (hotdata-runtime>=0.2.1).
- HotdataMarimoEngine: add default_database= constructor param, pass to execute()
- SqlEditor: add database= constructor param, pass to both execute_sql calls
- ManagedDatabaseWriter: use description= kwarg matching ManagedDatabase v0.2.0 API
- Fix test_databases_marimo.py syntax error and update assertions
* refactor: eliminate flag-based side-effect tracking, fix unregister, remove dead code
- table_browser: extract _set_table_pick() replacing duplicate _init/_rebuild methods;
_sync_table_catalog returns bool so ui drops _rebuilt_table_pick_this_run flag;
standardize _active_connection_id to use 'or None' consistently
- sql_engine: unregister now restores original engine_to_data_source_connection and
resets sentinel so register/unregister/register round-trip works correctly
- sql_editor: remove dead 'or ""' on _cached_sql (already guarded by None check above)
- workspace_selector: cache HotdataClient, only reconstruct when workspace_id changes
* fix: pass dropdown label key (not value) to mo.ui.dropdown value= init param
When options is a dict {label: value}, Marimo validates value= against the
dict keys (labels), not the values. _rebuild_database_pick was passing a
database ID (dict value) which raised ValueError on startup. Now resolves
the label key corresponding to the previously-selected ID instead.
* docs: rewrite README with quickstart and usage examples
* chore: remove publish-workflow.sh scaffold (workflow already generated)
* refactor: simplify redundant expressions in display and workspace_selector
---------
Co-authored-by: Eddie A Tejeda <669988+eddietejeda@users.noreply.github.com>1 parent 0c40968 commit abf9ec6
2 files changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
94 | | - | |
| 93 | + | |
95 | 94 | | |
96 | 95 | | |
97 | 96 | | |
98 | 97 | | |
99 | 98 | | |
100 | | - | |
| 99 | + | |
101 | 100 | | |
102 | 101 | | |
103 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
0 commit comments