-
Notifications
You must be signed in to change notification settings - Fork 0
Use runtime workspace resolver in Marimo #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
38a286a
Use runtime workspace resolver in Marimo selector.
eddietejeda 4929c60
Refresh uv lock metadata for runtime dev dependencies.
eddietejeda b0482c3
Prevent option collisions in Marimo pickers.
eddietejeda c1b6ef1
Align Marimo imports and table metadata resolution with runtime contr…
eddietejeda 155f587
Use runtime summaries in Marimo display views.
eddietejeda 9cee4c7
Broaden runtime import guardrail detection.
eddietejeda 57cb511
Document marimo example entrypoint in README.
eddietejeda 847663f
Remove HOTDATA_TOKEN messaging from marimo integration.
eddietejeda 5011915
Make the marimo example runnable without tpch-specific setup.
eddietejeda 2183373
Expand the marimo example into a multi-widget demo.
eddietejeda ac68bbc
feat: add HotdataMarimoEngine for mo.sql
eddietejeda dd4e290
feat: export SQL engine registration from package
eddietejeda 5509eb6
docs: rename example to demo.py and document HOTDATA_WORKSPACE_ID
eddietejeda 0e1113d
docs: use HOTDATA_WORKSPACE env var
eddietejeda 367a9ff
docs: add marimo feature overview
eddietejeda 77feaab
refactor: tighten Hotdata marimo SQL engine imports
eddietejeda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the prior code raised
RuntimeError("No Hotdata workspaces found for this API key.")before reaching the picker logic. With this refactor, ifresolve_workspace_selectionreturnssource != "explicit_env"with an emptyworkspaceslist, neither branch fires and we fall through to build a dropdown withoptions={}(andselection.workspace_idis whatever the runtime defaulted it to). Either confirm the runtime contract guarantees a non-empty list / raises for this case, or restore an explicit guard here so the failure mode stays a clear error rather than a broken dropdown. (not blocking)