-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add database= parameter to sql engine and editor for managed database scoping #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
f1f6188
feat: add database= parameter to sql engine and editor for managed da…
eddietejeda b1f9d5c
refactor: eliminate flag-based side-effect tracking, fix unregister, …
eddietejeda 1e56b56
fix: pass dropdown label key (not value) to mo.ui.dropdown value= ini…
eddietejeda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: (not blocking) two subtleties here worth a quick check:
Dropdown value semantics changed from name to id. Previously
database.valuewas the database name; now it's the id. That id is then passed positionally toload_managed_table(database, ...)in_maybe_load(line 189). Worth double-checking that hotdata-runtime 0.2.1'sload_managed_tableaccepts the id as the first arg (vs. the old name) —test_managed_database_writer_loads_parquetstill assertsload_managed_table.assert_called_once_with("sales", ...)and only passes because the dropdown is mocked, so it doesn't actually validate the new behavior.Description collisions silently collapse. Two managed databases with the same description (or both unset, falling back to
db.idwhich is unique — that case is fine) collapse to a single dropdown entry because dict keys must be unique. Probably rare, but consider disambiguating, e.g.{(db.description or db.id) if uniq else f"{db.description} ({db.id})": db.id for ...}or just including the id in the label unconditionally.